Giter VIP home page Giter VIP logo

Comments (4)

shyamd avatar shyamd commented on August 31, 2024

Is it possible the task_type functionality isn't working for these calcs or is just in the materials docs where this is going awry?

from emmet.

rkingsbury avatar rkingsbury commented on August 31, 2024

This is actually in the task docs (or whatever it is that the Tasks endpoint serves from) not the materials docs . Could this be a simple question of when the tasks were ingested? In my personal tasks collection, none of my tasks has a task_type field.

The validation and materials collections associated with my PR #536 (building with the new build system) on Knowhere / mp_core_build appear to have correctly-populated calc_type and calc_types fields, respectively.

from emmet.

shyamd avatar shyamd commented on August 31, 2024

The task docs won't have a valid task_type since I think that was hot-patched for a short while until I realized that even pymatgen was buggy and decided that it should be in the Materials Doc.

from emmet.

mkhorton avatar mkhorton commented on August 31, 2024

In that case, we should probably remove task_type from the API doc?

I see the value in having it from the tasks endpoint directly, but since it needs to be built separately, one option would be to offer a /tasks/task_types route. Another option would be an on-the-fly aggregation, so that the returned task doc has the built task type, but that would probably mean we couldn't search on it.

from emmet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.