Giter VIP home page Giter VIP logo

Comments (14)

JaGeo avatar JaGeo commented on July 26, 2024 1

@munrojm Awesome! 🥳 Thank you so much!

from emmet.

munrojm avatar munrojm commented on July 26, 2024 1

@JaGeo, feel free to try pulling the data with the latest MPRester and let me know what other changes you would like to make. We are going to be working on website integration soon.

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

I think I will just make a pull request for the option where we only do the analysis when oxidation states are available. I will comment the other code for now. It runs at least twice as fast and should also be easier to understand for users if only one type of ChemEnv analysis is used.

from emmet.

munrojm avatar munrojm commented on July 26, 2024

@JaGeo, just pinging you here to let you know I am debugging some builder pipeline issues which is delaying me on getting the chemenv stage up and running. This should be done soon, and I will update this thread.

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

@munrojm Thanks for the update! 🙂

from emmet.

munrojm avatar munrojm commented on July 26, 2024

@JaGeo, the builder runs well! I am able to get it completed in ~5hrs within our build pipelines. The data should be incorporated into the DB and available through the API next release.

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

@munrojm If there is more documentation needed to make this available, just let me know. I am happy to help with this as well.

from emmet.

munrojm avatar munrojm commented on July 26, 2024

@JaGeo, I appreciate the offer. Apologies again for the delay on this. This is essentially ready to go on the API side. Our initial intent was to wait to bundle this with some other data in the next DB release, but that kept getting pushed back for a number of reasons. Currently, I am working to fix up thermo data related issues. We intend to deploy again soon with to accommodate the changes. What I will do is include the ChemEnv data in that deployment so it is available next week.

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

Great, thank you!

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

I do have an additional question: would it be in principle possible to get a DOI for such a dataset (the whole one)?

from emmet.

munrojm avatar munrojm commented on July 26, 2024

@JaGeo The DOIs we get from OSTI need to be matched to a landing page. Dataset contributions to core and not MPContribs don't have that, and thus we can't assign DOIs for them. @tschaume can weigh in on this in case I am getting something wrong.

On another note, do you have any particular things you would like to have included as filters on the chemenv data within the API? chemenv_iucr for example?

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

@munrojm I think a filter on the environment names would be good: chemenv_iucr, chemenv_name, chemenv_iupac and maybe also a filter on the "continous symmetry measure" (csm) to exclude very distorted environments,, for example. We also already show some outputs from ChemEnv on the materialsproject toolkit page. There, we also display wyckoff_positions, and species and the name chemenv_name.

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

Thank you, @munrojm ! I will try to test it during this week!

from emmet.

JaGeo avatar JaGeo commented on July 26, 2024

@munrojm, I was too curious and I added some suggestions here: materialsproject/api#771

from emmet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.