mathiasmeuleman / react-pdf-selection Goto Github PK

I am trying to set a newAreaSelectionComponent that has a popover where the user can enter some more data about the selection before saving it. The problem I am having is every time I click into the Popover it triggers a reset of the newAreaSelectionComponent. How can I programatically control reseting when the newAreaSelectionComponent is closed so losing focus does not automatically reset the selection.

         newAreaSelectionComponent={(boundingRect)=>{
                return(
                    <CustomSelectionComponent  boundingRect={boundingRect.boundingRect} selectionPageNumber={selectionPageNumber}/>
                    )
            }}

        <Popover>
                <div
                    style={{
                        ...boundingRect,
                        position: "absolute",
                        border: "1px dashed #333",
                        background: "rgba(252, 232, 151, 1)",
                        mixBlendMode: "multiply",
                    }}
                />
          </Popover>

Pdf File with 270 page rotation

Expected behavior

In your API Reference in Readme.md position property of SelectionType is NormalizedPosition.

However in the source code in types.ts we can read that both TextSelectionType and AreaSelectionType have position of type Position not NormalizedPosition.

Is this intended?

Currently, selecting text that spans multiple pages will only result in the text on the first of those pages being properly selected. It would be nice if this library would support multi-page text selections.