matricci / plank-adp Goto Github PK

CodeFactor found multiple issues:

Starting a process with a partial executable path

src\utils.py:16

Starting a process with a shell: Seems safe, but may be changed in the future, consider rewriting without shell

src\utils.py:16

Comparison to False should be 'not expr'

src\utils.py:15

CodeFactor found multiple issues:

Comparison to True should be just 'expr'

src\main.py:96
src\main.py:54
src\main.py:44

Comparison to None should be 'expr is not None'

src\main.py:57

I'm on Cinnamon, running Linux Mint 19.1 Tessa 64-bit
As per your project description, it seems Cinnamon is now supported. So I went further with it to see how it goes.
At first, installer.sh runs a check and determines Python pip and Dconf-tools are installed. Then, it goes after Pillow (Python Image Library) by itself (you provided the dependency Python Pillow with a space, so I can't figure that out. Perhaps you're referring to python-pil?) Anyways, it finds and installs Pillow 6.1.0. And then this happens:

 Collecting Pillow
  Using cached https://files.pythonhosted.org/packages/cc/a4/79b5f36d1e1a2b426073bd62217d1530fcd939950c2936651e6b39127a9b/Pillow-6.1.0-cp27-cp27mu-manylinux1_x86_64.whl
Installing collected packages: Pillow
Successfully installed Pillow-6.1.0
Collecting pycairo
  Using cached https://files.pythonhosted.org/packages/48/20/5e83af98eb897935bf7dc39455e892ba866feebb9b7c3b392982866f9958/pycairo-1.18.1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
ImportError:  No module named setuptools

The same goes for PyGobject, it collects, then setup.py triggers the same ImportError error message. Because of that, I guess PyGobject isn't installed, which triggers the following:
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-JovOND/PyGobject/

As a result, plank-adp won't show up.
Have you tried plank-adp on Linux Mint Cinnamon? If so, does it work out of the box for you?