Giter VIP home page Giter VIP logo

coloratio's Introduction

coloratio's People

Contributors

ellakaye avatar matt-dray avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

coloratio's Issues

Is `cr_choose_col()` redundant?

I think cr_choose_color() mostly does the job of cr_choose_bw(), unless you provide ex_bw = TRUE. Excluding black, white and greys will just mean the next most-dark and most-light will be provided though, right? And won't those almost always be navy and snow, etc?

Run cr_choose_color() with ex_bw = TRUE against all named colours to see whether it's just the same few colours each time.

Vectorise cr_choose_*()

This would make these functions usable in ggplot2::after_scale(), easily solving a common problem not solved elsewhere.

Providing a faux-vectorised version using purrr or *apply might be acceptable as a quick fix but suboptimal performace-wise - I am currently using a purrr-based wrapper for this purpose.

Suggest `farver::decode_colour()` instead of `cr_choose_bw()`?

The scales::show_col() function uses {farver} to decide whether to choose black or white:

hcl <- farver::decode_colour("snow", "rgb", "hcl")
hcl
#             h        c        l
# [1,] 12.17432 2.884795 98.64389

ifelse(hcl[, "l"] > 50, "black", "white")
#       l 
# "black" 

It grabs the luminance of the provided colour and selects black or white, depending. Is this better than cr_choose_bw(), which works out which of white and black has the highest contrast with the cupplied colour according to cr_get_ratio()?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.