Giter VIP home page Giter VIP logo

Comments (1)

GenieTim avatar GenieTim commented on August 11, 2024

Hi and thanks for reaching out!

I see both pros and cons to this:

Cons:

  • breaking change (fix: major version)
  • one full-blown dependency more
  • separate discussion possible which package to use
  • much work to do (possibility e.g. "adabt" the package implementing TreeishInterface)
  • "if it ain't broke, don't fix it"

Pros:

  • one thing less to maintain & test here
  • a separate implementation might be better known/more familiar to users
  • reminder to refactor methods allowing too many input types (example)

I see it as a valid option for a next major version of this library (if @imunhatep does not have major concerns), but not something I would spend time on changing myself.

from gitelephant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.