Comments (5)
Well, switching to array would be a much bigger task. I get started with copying the 5 files and updating the dependency, then you can have a look and make your decision.
from gitelephant.
The one feature that is actually in use from this package seems to be \PhpCollection\Sequence.
I can also imagine trying to get rid of it completely.
I might tackle this earliest starting next year, but feel free to submit a PR, I will gladly merge it if appropriate.
from gitelephant.
This looks pretty straight forward. There are 3 classes and 2 interfaces that would have to be copied into this project here:
- AbstractCollection
- AbstractSequence
- CollectionInterface
- Sequence
- SequenceInterface
And a new dependency for phpoption/phpoption would be introduced.
Is that the way to go? If so, I'm happy to put that into a PR.
from gitelephant.
...or replace it with arrays. That would be a breaking change, but as I see it, reducing such overhead that is not required for functionality is a positive thing.
Feel free to open a PR switching the composer dependency, I guess that would be fine already for now.
from gitelephant.
Created first PR and left the original comments in the files from the other package for now. Also, code style is complaining as the code was taken from the other repository. Can be addressed iof the general approach is being decided.
Turned out, that there was also a use-statement for the PhpCollection\Map class, but it seems that wasn't ever really used, so I've removed that too.
from gitelephant.
Related Issues (20)
- getBranches() fails when the repository is in a detached state HOT 1
- [Q] What are the necessary permissions? HOT 3
- PHP 7.2 breaks project because of "Object" type-hint HOT 2
- dev-develop branch breaks composer HOT 2
- Symfony 4 HOT 2
- Make LC_ALL call optional on Windows HOT 2
- live example website is down ? HOT 3
- Problems with Stash and Pop HOT 6
- Error calling all the functions HOT 1
- git pull origin HOT 4
- GitElephant for Enterprise HOT 5
- Update composer.json to allow sf5 versions of dependencies HOT 1
- Process::fromShellCommandline($cmd, $cwd); fails HOT 4
- v4.1.1: Call to undefined function GitElephant\Command\is_countable() HOT 3
- Replace Repo::getTree() with a contrib Tree implementation HOT 1
- PHP 8
- git add . HOT 1
- PHP 8.1 compatibility fix for deprecated return
- More PHP 8.1 deprecations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitelephant.