Giter VIP home page Giter VIP logo

Comments (8)

cwarnermm avatar cwarnermm commented on September 14, 2024 1

Thank you, @dipak-demansol! This context is very helpful. I agree with your assessment that we can remove the "try again" text. Let's go with your recommendation of "Failed to disconnect user. Connect the user account to Microsoft Teams."

from mattermost-plugin-msteams-meetings.

dipak-demansol avatar dipak-demansol commented on September 14, 2024

Pls assign This to me.

from mattermost-plugin-msteams-meetings.

dipak-demansol avatar dipak-demansol commented on September 14, 2024

before, when then user disconnect the account again then user was getting this validation message
image

and now From that message i removed err= and the message looks like this
image

@cwarnermm i did the changes on that message by removing that err= but still is there any improvement we can do? or that validation message is Look good to you?

from mattermost-plugin-msteams-meetings.

cwarnermm avatar cwarnermm commented on September 14, 2024

Thanks, @dipak-demansol, for reaching out. I appreciate it.

Let's update this message to: "Failed to disconnect user. Connect the user account to Microsoft Teams, then try again."

from mattermost-plugin-msteams-meetings.

dipak-demansol avatar dipak-demansol commented on September 14, 2024

Thanks, @dipak-demansol, for reaching out. I appreciate it.

Let's update this message to: "Failed to disconnect user. Connect the user account to Microsoft Teams, then try again."

Thank you for the reply, i have some thought about that message.
:- i suggest we should remove that "then try again" text because user is already not connected and as per this message we're saying that connect account then try again to disconnect, i think our validation message focus should be on to tell user to connect account not to try again for disconnection.
if you still Confirm that we should use the validation message that you provided then pls let me know, ill use that.

from mattermost-plugin-msteams-meetings.

dipak-demansol avatar dipak-demansol commented on September 14, 2024

Thanks, @dipak-demansol, for reaching out. I appreciate it.
Let's update this message to: "Failed to disconnect user. Connect the user account to Microsoft Teams, then try again."

Thank you for the reply, i have some thought about that message. :- i suggest we should remove that "then try again" text because user is already not connected and as per this message we're saying that connect account then try again to disconnect, i think our validation message focus should be on to tell user to connect account not to try again for disconnection. if you still Confirm that we should use the validation message that you provided then pls let me know, ill use that.

@cwarnermm

from mattermost-plugin-msteams-meetings.

cwarnermm avatar cwarnermm commented on September 14, 2024

Thanks, @dipak-demansol! Can you help me understand the context of this message, please? What is the user doing when this message appears?

  • who is doing the disconnecting?
  • are they disconnecting themselves or someone else?
  • what are they disconnecting someone from exactly?

Thanks!

from mattermost-plugin-msteams-meetings.

dipak-demansol avatar dipak-demansol commented on September 14, 2024

Thanks, @dipak-demansol! Can you help me understand the context of this message, please? What is the user doing when this message appears?

  • who is doing the disconnecting?
  • are they disconnecting themselves or someone else?
  • what are they disconnecting someone from exactly?

Thanks!

@cwarnermm
:- who is doing the disconnecting?
A :- consider i'm the user and i'm disconnecting my self

are they disconnecting themselves or someone else?
A :- themselves

what are they disconnecting someone from exactly?
A :- they Connected with msteem plugin and User Disconnected themselves and user again using the same disconnect command to disconnect themselves so as per the old validation "we're telling to user that disconnect command failed, first connect the account to microsoft"

from mattermost-plugin-msteams-meetings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.