When i Use /mstmeetings help xyz then its ignore the extra parameter and give me the right output but when i use /mstmeetings start xyz or /mstmeetings disconnect xyz then it gives me the validation as "Too many parameters." but i expect start & disconnect should work same as help, it should not give the validation, it should ignore The Extra parameter.

Update license as Source Available.

just a test

Currently when The User Disconnect account 2nd time then user is getting validation as "Failed to disconnect the user, err=must connect user account to Microsoft first" but we should not show text as err=.

simple Fix Should be just remove that text and The validation should be Failed to disconnect the user, must connect user account to Microsoft first

The .circleci/config.yml file needs to be updated to run the webapp tests in CI.

Mark as done after each step completed

As the individual doing plugin intake, you will need the following privileges.

• Github repository admin access. You will see the Settings option tab if access has been granted. (next to Pull requests, Actions, Releases)
• Mattermost Channel admin access. This will allow editing the channel header

The following options require Mattermost admin privileges. If you don't these (likely) ask management

• Mattermost sysadmin access.
  • Needed for creating new public channels
  • Needed for /jira subscribe if applicable

Repository Setup - Settings

• Options (Make sure the following are the only selected items)

  • Features:
    • Wikis
    • Restrict editing to users in teams with push access only
    • Issues
    • Projects
  • Data services
    • Security alerts
  • Merge Button:
    • Allow squash merging
    • Automatically delete head branches

• Setup GitHub 1st Project

  • Projects > New Project
  • Board Name: v1.0
  • Description: First shippable version, to be submitted to the plugin marketplace.
  • Add Columns: Use https://github.com/mattermost/mattermost-plugin-solar-lottery/projects/1 as a template

• Collaborators (Manage Access)

• Added the following:

  • mattermost/core-build-engineers
  • mattermost/core-committers
  • mattermost/core-developers
  • mattermost/core-pms
  • mattermost/integrations
  • mattermost/qa-core-team
  • mattermost/tech-writers

• Branches
  Branch protection Rules: master should already be available. Click edit next to master and verify the following defaults

• Branch name pattern: master

  • Applies to 1 branch: master

• Protecting matching branches

  • Require pull request reviews before merging: required approving reviews :2
    • Dismiss stale pull request approvals when new commits are pushed
  • Require status checks to pass before merging
    • Require branches to be up to date before merging

• Webhooks

• Add codecov.io, create the webhook from codecove.io/gh/mattermost/mattermost-plugin-

  • Settings > General > GitHub Webhook > Create new webhook
    • This will add the webhook to GH. View in GH > Settings > Webhooks

• CircleCI (DONE - Don't need to do because exists from OSS forking)

  • login into https://circleci.com/gh/mattermost > Add Projects > search for plugin repo > Set Up Project > Start Building
  • copy https://github.com/mattermost/mattermost-plugin-demo/blob/master/.circleci/config.yml into local plugin repo (No edits needed)
    • Submit as PR
    • Title: Update CircleCi
    • Description: Sync to latest https://github.com/mattermost/mattermost-plugin-demo/blob/master/.circleci/config.yml
  • Add to CircleCI from circleCI (adds the webhook and deploy key)

• Mattermod

  • Payload URL: https://mattermod.mattermost.com/pr_event
  • Content Type: application/json
  • Secret: ?? Where to get secret?
  • Which events to trigger webhook?
    • Let me select individual events
      • Issue Comments
      • Issues
      • Pull requests
      • Select Active

Install GitHub Apps

• CircleCi Checks
• Dependabot Preview

README.md

• add circleci badge
• add codecov badge
• add go report badge

If these don't exist, create Tickets for each (these are available in the Demo page)

• Add HW to Readme
• Slash commands documented
• Images added
• Installation / Configuration section added

Repository checks

Each of the following might require new commits and PRs against master.

These are 1:1 with the Open source repo.

• go mod tidy
• version
• All tests passing
• npm audit fix
• npm-check -E -u to view the changes interactively
• npm-check -E -y to update without interactive
  • check in package-lock.json and package.json
• grep for original repo references in all files

Mattermost Channels Setup

• Plugin: <plugin_name> - setup new plugin channel
  • Add plugin author and some other integration team members
  • Github subscribe
    • /github subscribe mattermost/mattermost-plugin-solar-lottery pulls,issues,creates
  • (n/a) Jira subscribe - need an epic!!! (or what? Really need components?)
  • Header: [HW] | [repo] | [circle-ci] | PM: | Dev:

Actual text for header - replace all instances of <plugin_repo>, <pm-name>, <dev-name>

[GitHub](https://github.com/mattermost/<plugin_repo>) | [Help Wanted](https://github.com/mattermost/<plugin_repo>/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22up+for+grabs%22+label%3A%22help+wanted%22+sort%3Aupdated-desc) | [![CircleCI](https://circleci.com/gh/mattermost/<plugin-repo-namme>.svg?style=shield)](https://circleci.com/gh/mattermost/<plugin-repo) | PM: @<pm-name> | Dev: @<dev-name>

• GitHub subscribe in ~Plugin Heartbeat channel
  • /github subscribe mattermost/mattermost-plugin-solar-lottery pulls

The rest

• Labels: add to mapping.go#L7 and cd labels && go run . -default -v
• Add to tracking spreadsheet, https://docs.google.com/spreadsheets/d/1jPuvFdeaWJy_-faP-p71_x66OC4x6Udp8vrasrJzbEo/edit#gid=1550130552
• Add to pinned issue links in mattermost/mattermost#12656
  • add repo to Good First Issue link (listed alphabetically)
  • add repo to Up For Grabs - Golang link (listed alphabetically)
  • add repo to All Plugin Up For Grabs link (listed alphabetically)
  • add repo full list of repositories
• Setup Jira Epic plugin <plugin_name>
  Mattermost Team: Integrations
  There is no Jira Epic for this plugin. All issues will be handled in GitHub

Should we warn the user before posting a meeting in a populated channel? What can be considered a "populated channel"? Any public channel?
Should we add some setting to avoid posting meetings on public channels?

cc @aaronrothschild

Meeting creation allows you to add the people to the meeting directly. This will make it so you don't have to give permission to enter the meeting to each one.

The idea of this ticket is to add all people signed in into MSTeams Calling that are on the channel to the meeting.

Right now we will be needing several different icons:

• Marketplace icon
• Bot profile picture
• Channel header icon
• Meeting started icon
  

Instead of allowing the plugin to run if an E20 license is enabled, it should also run if development mode is enabled.

The new check should make use mattermost/mattermost-plugin-api#72 and be similar to https://github.com/mattermost/mattermost-plugin-incident-response/blob/c17fa2029a3f855b2a0f41510e4b3485a05744c5/server/plugin.go#L57-L59.

As Beta to the Marketplace

• #15
• #19
• #20
• #26
• #27

Improvements

d0e5b4d [MM-38103] Include professional and enterprise SKUs in license check (#51)
285052b add command icon (#54)

Fixes

0278e8c fix error variable issue (#52)

Maintenance

65aa706 go mod tidy (#48)
132b9d0 Update installation-and-configuration.md (#46)
76e4f06 Add missing period in settings help text (#44)

in the desktop app after run the /msteem start command i'm getting UI like this

and i'm Expecting the UI like this

i'm using the same server for Web & Desktop app and i'm Using The Master build.

Channels (public and private) may have lots of people in the channel, and creating a meeting on those is oftentimes a mistake or a missclick. We would like to add a confirmation message when creating a meeting on public and private channels, warning the user they are about to create a meeting in a channel with X users, with a button to create the meeting either way.

Hello @larkox,

It's possible to release a new version to integrate the work of @javaguirre ?

Thank you

Currently when user type /mstmeetings Start then if user is not connected then user will get the link to connect so there should be separate command for connect same as other plugins.

Meetings can have a subject. How do we want to provide the subject?

Shall we use the same behaviour as Jitsi?

This plugin seems to no longer require an E20 license (#80) to function 🎉, but the installation docs still mentions this as a requirement. Can this requirement be removed from the docs?

For MS Teams collision detection, there is a delay of a few seconds when there is an existing meeting and the user clicks Create New Meeting

If the user mashes the button by clicking it many times during this delay it can produce an error in an ephemeral post. The user will then see one meeting creation post for each of the times they've click the button.

I was not able to repro this on Zoom. I also don't see this same 2-3 second delay when creating a new meeting from the collision post.

There is no issue with the Create New Meeting button if you just wait for a few seconds for your new meeting to launch.

Steps

• Setup MS Team Calling
• Start a meeting
• Click the connect link and map the user is needed
• Immediately start a 2nd meeting
• When the collision post appears - Mash the Create New Meeting button very quickly
  Observed:
  

Meeting posts should have a "meeting_provider" to allow other plugins to handle recent meetings. Also, this plugin should equally handle those.

Webapp plugin is throwing this error:

index.js:3 Uncaught ReferenceError: process is not defined
    at Object.b (index.js:3)
    at __webpack_require__ (bootstrap:18)
    at Object.<anonymous> (hoist-non-react-statics.cjs.js:3)
    at __webpack_require__ (bootstrap:18)
    at Module.<anonymous> (displayName.js:23)
    at __webpack_require__ (bootstrap:18)
    at Module.module.exports (utils.browser.esm.js:40)
    at __webpack_require__ (bootstrap:18)
    at Module.<anonymous> (com.mattermost.msteamsmeetings_bc87e61d204c5460_bundle.js:5815)
    at __webpack_require__ (bootstrap:18)

Here's the file that's throwing the error:
node_modules/react-is/index.js

'use strict';

if (process.env.NODE_ENV === 'production') {
  module.exports = require('./cjs/react-is.production.min.js');
} else {
  module.exports = require('./cjs/react-is.development.js');
}

There seems to be an intermittent issue where the tab used to authenticate to Azure shows invalid state.

This did not occur on each attempt. Interestingly. The user connected without issue and there seem to be no functional problems.

I saw no indication in the logs as to why the browser said invalid state and the authentication seemed to work fine.

Steps used:

• Login to Mattermost
• Type /msteams start
• Click the connection link (opens in a new tab)
• Provide credetials

Observed: Invalid State
Expected: Message that authentication succeeded and I should close the tab.

When there are only a few plugins enabled that have a plugin icon in the header the MS Teams Icon is no longer showing. The icon only shows in the collapsed menu.

Missing here...

The button is just styled in a way that makes it invisible.

This bug is happening when I have my MM server running the master branch. Seems possible this is a bug I missed when testing #27

The plugin seems otherwise running and functional.

• Under each text box explain what it is for
• Add a link to gitbook docs - pages about installation.

Currently I'm facing an issue while link microsoft account. You please help to advise. Thank you

Err msg:
Post "https://login.microsoftonline.com/e310c9e5-4531-4482-b592-676587725124/oauth2/v2.0/token": x509: certificate is not valid for any names, but wanted to match login.microsoftonline.com

When MS teams calling is enabled along with several others, there is missing white space between the plugin icon and title

Hi,

I am very enthusiastic about using this plugin, as I might be able to continue using MM and avoid switching fully to teams for messaging :D

I tried installing the plugin on a gitlab omnibus provided instance using the .tar.gz 1.0.0 file, and I got a 400 from the server.

Message in the tool is : Received invalid response from the server.

400 in FF console is : POST https://mattermost.clap-labs.fr/api/v4/plugins -> 400 bad request.

I tried to use the plugin marketplace as suggested in the install guide, but I could not find the plugin in it (I am using this one https://api.integrations.mattermost.com/)

I did not find anything in the logs regarding the issue.

Mattermost Team Edition
Mattermost Version: 5.31.1
Database Schema Version: 5.30.0
Database: postgres

Add Enterprise check to not allow the plugin be run unless you have an E20 license installed.

With 1 particular user, I am seeing the authentication process return a 500 and the plugin will crash.
Other user are not affected.

In any case, we should handle this to prevent the crash should anyone else come accross a case like this where something seems to be invalid with the users.

See logs

{"level":"debug","ts":1603489636.774614,"caller":"web/handlers.go:100","msg":"Received HTTP request","method":"POST","url":"/api/v4/logs","request_id":"ho6mugii7bb5jbct4367eni1ge","status_code":"200"}
{"level":"debug","ts":1603489643.640474,"caller":"wsapi/websocket_handler.go:25","msg":"Websocket request","action":"user_update_active_status"}
{"level":"debug","ts":1603489647.0510972,"caller":"plugin/hclog_adapter.go:53","msg":"panic: runtime error: invalid memory address or nil pointer dereference","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.05122,"caller":"plugin/hclog_adapter.go:53","msg":"[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1e792b6]","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.051265,"caller":"plugin/hclog_adapter.go:53","msg":"","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.0513,"caller":"plugin/hclog_adapter.go:53","msg":"goroutine 6370 [running]:","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.0513449,"caller":"plugin/hclog_adapter.go:53","msg":"main.(*Plugin).completeUserOAuth(0xc000387900, 0x2620680, 0xc0005f9650, 0xc000294300)","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.051382,"caller":"plugin/hclog_adapter.go:53","msg":"\t/Users/dylanhaussermann/go/src/github.com/mattermost/mattermost-plugin-msteams-meetings/server/http.go:137 +0x7d6","plugin_id":"com.mattermost.msteamsmeetings"}
{"level":"debug","ts":1603489647.0514162,"caller":"plugin/hclog_adapter.go:53","msg":"main.(*Plugin).ServeHTTP(0xc000387900, 0xc00007ae40, 0x2620680, 0xc0005f9650, 0xc000294300)","plugin_id":"com.mattermost.msteamsmeetings"}

There is an intermittent error where users must click the connection link a 2nd time. On the 1st attempt the new tab shows the message about needing to connect the user first.
Clicking the link a 2nd time then works as expected.

Unfortunately there is very little info on how prevalent this issue is. The issue may be HA related.
Most extensive testing showed it occurred 2/10 time on a server with 2 cluster instances.

What was determined is that issue does occur on v1.0.1 and is not new to upgrading to version v2.0.0

Maybe requires a separate issue but on occasion the following error can also occur in similar conditions.

When MS Teams is moved to the app bar, the tooltip seems to change. The plugin now shows the plugin ID instead of the previous tooltip about starting a meeting.

Short of the App Bar, I see so other change causing the tooltip to change. Likely this was missed in testing when MS teamms registered a new icon in the App Bar

Note: Not sure on the solution here as I believe the more permanent place for this is in the new Calls componenet

Add telemetry, similar to that on Zoom.

Make sure that numbered lists don't reset to 1. after screenshots

Make sure images render correctly, e.g. <img width="500 src="https://user-images.githubusercontent.com/6913320/76348298-55cd4880-62de-11ea-8e0e-4ace3a8f8fcb.png"/>

Make it clear whether you need an Office365 subscription and/or account for Teams to work

Make sure screenshots of permissions show the minimum necessary permissions for the teams plugin to work and also list these permissions as text

Add note that you must be an admin to grant admin consent, and that if the option is greyed out you need to to contact your Azure administrator