mattiasgeniar / varnish-3.0-configuration-templates Goto Github PK

These templates work really great, thanks for sharing. I did however come acrosss one issue with Joomla sites that are set to offline mode, that require front end login to access. They just produce a 503 at the moment. If I just set the same site to online mode it works normally, also front end login works, it seems it is just offline mode that is broken somehow. Guess it's a cookie problem or similar.

This is a Joomla! 3.2.0 Stable [ Ember ] 6-November-2013 14:00 GMT

Hi, on line 58 there is: set req.grace = 15s;
However, since we ALWAYS set grace in line 60 or 63, why do you need initialization in line 58? I believe it is not needed (though it doesn't hurt either).

Mattias,

I've added some code for better Drupal logged-in user cache exclusion.
Forked in https://github.com/kbemelmans/varnish-3.0-configuration-templates

The VCL I normally use for our Drupal sites is https://github.com/NITEMAN/Varnish_VCL_samps-hacks
I think there are some more good defaults in there that could be copied into your drupal fetch and receive include files.

The README.md file doesn't actually contain any installation instructions. Users new to varnish will have no idea how to incorporate these files.

I think you should try adding a blank line at the end of .vcl files when GitHub isn't syntax highlighting them. For e.g., in your repo, this vcl file isn't being syntax-highlighted: https://github.com/mattiasgeniar/varnish-3.0-configuration-templates/blob/master/production.vcl

Wordpress preview mode doesn't seem to work unless I tack on "&wp-admin" to the URL of the previewed document. I've tried changing the wordpress.vcl files to

# Drop any cookies Wordpress tries to send back to the client.
if (!(req.url ~ "wp-(login|admin)" || req.url ~ "preview")) {
    unset beresp.http.set-cookie;
}

and

# Drop any cookies sent to Wordpress.
if (!(req.url ~ "wp-(login|admin)" || req.url ~ "preview=true")) {
    unset req.http.cookie;
}

But it hasn't changed anything. Do you have any ideas for getting wordpress preview mode working?

Hello,

I love the work you did with the templates but it seems there is no explicit license in this repository so I'm not sure if I can use it. Could you add a license please?