mattiasgeniar / varnish-6.0-configuration-templates Goto Github PK

I applied the vcl settings well, but after one page is cached and I open another page that is not cached, the page that was previously cached is missed and hit again.

Hi, there is a minor issue with using this snippet:

# Normalize the query arguments
set req.url = std.querysort(req.url);

The main problem here is that WordPress < 5.3.x doesn't like presorted url parameters (messes up wp-admin dashboard icons etc.)
Reference: https://core.trac.wordpress.org/ticket/45346

There's a patch-set for WordPress coming in the next release (slated for mid september alledgedly), but I guess this might actually affect other applications as well, if they require 'specific' ordering.

This function leaves the req.http.Host empty in when there's no Host header present. I saw this when monitoring an ip with Nagios check_http -I $ip

set req.http.Host = regsub(req.http.Host, ":[0-9]+", "");

I fixed it by checking if req.http.Host is not empty, but it should probably be the default in these templates.

if (req.http.Host) {
 set req.http.Host = regsub(req.http.Host, ":[0-9]+", "");
}

This if statement in vcl_purge req.method == "PURGE" causes my setup to loop and error out with "Too many requests" error when I send PURGE request. Counterintuitively, when I change it to req.method != "PURGE", PURGE works and everything is fine.

My setup is based on varnish-4.0-configuration-templates so my setup had req.method != "PURGE" from back when you first made this change based on this Github Issue.

But then it was changed back to req.method == "PURGE" in this commit.

Then in varnish-5.0-configuration-templates, it goes back to req.method != "PURGE".

This carries through in 6.0 default.vcl until this patch changes it again back to req.method == "PURGE"

I am just curious to understand these changes. For me, req.method != "PURGE" seems wrong logically but it's the only change that fixes my PURGE issue.

Note that I use NGINX as the backend and also for TLS termination so I am not sure if this is what causes this to appear like a bug to me.

Cheers

For a few years, Facebook has been adding an fbclid URL parameter to every external URL users visit from their website (and I presume also their app). Since Facebook's use is still somewhat prevalent, I was wondering if it would be useful to add that one to https://github.com/mattiasgeniar/varnish-6.0-configuration-templates/blob/master/default.vcl#L103 as well?

Error:
Message from VCC-compiler:
Symbol not found.
('/opt/bitnami/varnish/etc/varnish/default.vcl' Line 281 Pos 1)
sub vcl_miss {
###-----------

Running VCC-compiler failed, exited with 2
VCL compilation failed
/opt/bitnami/varnish/scripts/ctl.sh : varnish could not be started