mattkimmel / bin_packing.cr Goto Github PK

For the initial version of this lib, the one thing I didn't port from https://github.com/mak-it/bin_packing is the HTML export. @mak-it uses Ruby's ERB engine for this, but Crystal's ECR engine is significantly more limited. Maybe I'm missing a way to use the original template with ECR, but it also might be worth re-implementing this using a different templating lib (or just re-implementing from scratch). It would be cool to be able to use the original templates, to make it easier to pull updates from the Ruby project.

The initial code for this project was copied and pasted directly from https://github.com/mak-it/bin_packing, and then modified as minimally as possible to get tests passing in Crystal.

It would be good to audit the code and do a few things, including but not limited to:

• Changing Ruby idioms to Crystal idioms where possible
• Putting in more explicit typing--the type inference engine is doing a lot of work and the code isn't all that readable
• Fixing up the specs a bit, e.g. should eq true becomes should be_true, and so on

This is probably an ongoing task, but here's an issue to track it.