mattnish / rad Goto Github PK

The Leaderboard ad in the demo doesn't seem to be scaling for me.

Strangely enough, bug #3 was only fixed in rad.min.js but not rad.js or maybe I am missing something?

First off I would like to say thanks. I've been working on a responsive design for something for a few days now and was starting to integrate the ads in and was surprised to see Google had no method available to dealing with that. Your plugin works quite well.

I found one little problem. I'm using a highly modified version of Bootstrap and the span# tags have margins set. The plugin didn't take into account margins so the result was the ad was the width of the margin wider than the span# block. I made this modification:

Directly below line 62 (var pWidth = this.adParent.width();)

I added this:

pWidth -= (parseInt(this.adParent.parent().css('marginLeft').replace('px', '')) + parseInt(this.adParent.parent().css('marginRight').replace('px', '')));

This seems to have done the trick resulting in the ad being sized correctly.

Thanks once again for the plugin.

Stewart

I have implemented this code on my site for the top 728x90 banner:

http://www.protoolreviews.com

Unfortunately, though the js file seems to be called correctly and all other code insertions seem to match your example page, I can't get the banner to resize.

Is it possible that the location of the banner within the theme is preventing the script from properly executing?

I'd love any feedback you may have on this.

Id given to