Game.prototype.raycastVoxels sometimes returns adjacent block that is not adjacent about voxel-engine HOT 7 CLOSED

I am seriously considering that both position and adjacent should be integer vectors instead, to fix this nonsense.

from voxel-engine.

I have a work-around in voxel-highlight (not committed) that pretty much takes that approach (convert hit position to voxel int coordinates array, then add normal):

  //var newVoxelPos = this.game.blockPosition(hit.position)
  var newVoxelPos = [
    Math.floor(hit.position[0]), 
    Math.floor(hit.position[1]), 
    Math.floor(hit.position[2])
  ]
  //var newVoxelAdj = this.game.blockPosition(hit.adjacent)
  var newVoxelAdj = newVoxelPos.slice()
  newVoxelAdj[0] += hit.normal[0]
  newVoxelAdj[1] += hit.normal[1]
  newVoxelAdj[2] += hit.normal[2]

Since this is a "voxel only" raycast and voxels can't move, maybe we don't need to know the exact hit or adjacent positions and can just use the voxel int coordinates? I guess it depends on what else this is used for -- highlight/erase/place only needs coordinates.

from voxel-engine.

1.999999999999999 === 2 but 1.99999999999999 === 1.99999999999999, so we could probably just truncate data after the 15th decimal place to get around this

from voxel-engine.

Actually, 1.9999999999999998 = 2.0 - MIN_FLOAT, and since (2.0-MIN_FLOAT) + 1 = 3, this is the intended behaviour. If you want the integer position of the hit, you can round it down to the nearest int; but getting the exact hit location is useful too. (For example, say you shoot a bullet and want to spawn a special effect at the point of impact.)

from voxel-engine.

i'm gonna Math.floor .position and use that to get .adjacent, and also return a new property voxel: [1,1,1]

from voxel-engine.

So we would get something like this back?

{
 position: [1.5503287987061696, 1.9999999999999998, 1.5288654983645178],
 voxel: [1, 1, 1],
 adjacent: [1, 2, 1],
 direction: [-0.16332358934799918, -0.4095857816495397, -0.8975326693959512],                                                                                     
 value: 1,                                                                                                     
 normal: [ 0, 1, 0 ]
}

That would be perfect!

from voxel-engine.

output is now:

# raycastVoxelsPrecise
{ position: [ 1.5503287987061696, 1.9999999999999998, 1.5288654983645178 ],
  voxel: [ 1, 1, 1 ],
  direction: 
   [ -0.16332358934799918,
     -0.4095857816495397,
     -0.8975326693959512 ],
  value: 1,
  normal: [ 0, 1, 0 ],
  adjacent: [ 1, 2, 1 ] }

from voxel-engine.