maxencefrenette / pub-crawl-planner Goto Github PK

Change it to https://maxencefrenette.github.io/pub-crawl-planner/

It would be great if all the changes made to the fields were reflected in the URL. Also, if the page is loaded with a prefilled url, the form should be filled accordingly. GET parameters should be the way to do it cleanly.

The demo url in the readme leads to a 404 error.

The PDF file should open in a new tab instead of navigating away from the form.

Main programming issue: browsers blocks tabs opened async. Therefore, all the calculation and pdf generation should be done on the new tab.

The online version of the Pub Crawl Planner is not working. It's missing the bundle.js file.

See here: http://berseker59.github.io/pub-crawl-planner/

When selecting a number of pub locations, the last input is focused instead of the first one (follows the flow of the form).

This bug does not happen on Google Chrome or Mozilla Firefox. Was only able to produce it on Apple Safari.

Step to reproduce

• Fill the form with pub crawl data.
• Click on generate PDF.
• Once the PDF is open, go back.
• The fields for the pub locations and the initial and final destination will be empty.

It happens whether or not there is an autofill url.

It can easily fit on one page height. Right now it causes unnecessary scrolling.

To reproduce:

• Set number of pubs to 1.
• Write Montreal, Quebec
• Set number of pubs to 2.

Result: The first pub location gets truncated to Montreal,.