maximadeka / convertkit-ruby Goto Github PK

Right now, this gem doesn't do any error handling. This introduces inconsistent behaviour in case of errors:

irb(main):001:0> client = Convertkit::Client.new
#<Convertkit::Client:0x00007f96030ecc20 @api_secret=nil, @api_key=nil>
irb(main):002:0> client.forms
nil
irb(main):003:0> client.custom_fields
nil
irb(main):004:0> client.subscribers
{
              :method => :get,
                :body => {
          "error" => "Authorization Failed",
        "message" => "API Key not present"
    },
... # this is Faraday::Response
irb(main):005:0> client.account
{
      "error" => "Authorization Failed",
    "message" => "API Key not present"
}

I could handle this in my own wrapper around this gem, but it would be much easier to handle errors directly in the gem. In that case we could raise errors based on on HTTP response, like:

• Convertkit::AuthorizationError for HTTP 401
• Convertkit::ServerError for HTTP 500
• Convertkit::BadRequest for HTTP 422
• Convertkit::ConnectionFailed instead of Faraday::ConnectionFailed
• etc.

@rkcudjoe Would you accept a PR which implements this?

Hey!

I just stumbled upon your library and I wanted to contribute. I just realized that the spec aren't mocking the HTTP calls, is it OK if I add webmock for example? That'd be easier to contribute then.

Please let me know what you think :)

If I grab this gem from RubyGems.org with v0.0.2, alot of the changes including Form and Account are not included in the gem.

Currently I need to define in my Gemfile file as follows:

gem 'convertkit-ruby', git: 'https://github.com/HookOps/convertkit-ruby', require: 'convertkit'

Can you please update the gem version on RubyGems.org?

Hi @rkcudjoe

I've noticed your gem is missing support for webhooks. I'm happy to contribute.
Do you accepts PRs?

Cheers

Definition in module Subscriber on line 31 is
def remove_tag_from_subscriber(subscriber_id, tag_id)

Definition in module Tags on line 17 is
def remove_tag_from_subscriber(tag_id, subscriber_id)

Which may lead to confusion.

Can we get a new release please? The current version of this gem on RubyGems.org is over 3 years old. A lot of new stuff has been added in that time, including the #remove_tag_from_subscriber method which I'd like to use.

Update README to show new installation instructions

Yank library from RubyGems and release package on GitHub

Update README to show that custom_field actions are now available as methods on the client object.