Giter VIP home page Giter VIP logo

Comments (5)

maximbaz avatar maximbaz commented on July 18, 2024

Good catch, thanks!

from docker-arch-build-aur.

maximbaz avatar maximbaz commented on July 18, 2024

I went for a hopefully future-proof approach, let me know if you still experience any issues!

from docker-arch-build-aur.

jannikw avatar jannikw commented on July 18, 2024

The . after tar prevents using no compression at all.

mv $package*.pkg.tar.* /pkg

So when specifying PKGEXT=.pkg.tar moving the package fails again.

I also noticed a related problem that is caused by the asterisks for moving the package. For example the AUR package zoom downloads an archive and calls it "${pkgname}-${pkgver}_orig_x86_64.pkg.tar.xz". After building the package (which basically repackages the archive) one is left with two archives called zoom-5.2.458699.0906-1-x86_64.pkg.tar.xz and zoom-5.2.458699.0906_orig_x86_64.pkg.tar.xz. Since both match the pattern, they will both be moved to the target directory. This isn't too bad, but not perfect either.

A possible solution I can think of is using PKGDEST from makepkg.conf. Since the makepkg user will probably have no write access to the /pkg directory, the directory cannot be specified directly using the variable. But one could specify a temporary empty directory. After building the packages that directory should only contain the package file, which means all files in that directory can be moved to /pkg, simplifying the glob pattern for moving the package further and avoiding problems with the file extension.

from docker-arch-build-aur.

maximbaz avatar maximbaz commented on July 18, 2024

Sounds good, would you be able to submit a PR? I don't want to over-complicate the scripts but your proposal sounds like it could be just one or two extra lines, so why not 😉

from docker-arch-build-aur.

jannikw avatar jannikw commented on July 18, 2024

Sure, i will give it a shot.

from docker-arch-build-aur.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.