maxime1992 / pizza-sync Goto Github PK

We definitely miss some E2E and unit tests.

Once they're here, Travis would be a nice fit for CI.

Would also be useful to enforce lint + prettier checks!

When the first user connects to the app, we should ask him when the orders should end.

Then, it should display a countdown and block the orders.

Node is single thread and serving the assets from the backend is really a bad idea.

The refactor of the backend to use Nest doesn't even serve the public folder in production anymore.

Nginx seems well suited for that use case:

• serve static content
• let HTTP calls to the api go through
• let websockets go through

Thanks to PR #51 (with docker), I noticed a weird thing in code:

I decided to use the local images directly from the frontend folder instead of using the ones from backend/public.

This is because while we develop, we don't have to build the frontend and put it in backend/public.

But with Docker, we only keep the backend folder and thus, we loose all local pictures.

As the app is growing up, the backend was designed in the most simple way at the beginning.

It would be a good idea to split it into models and controllers.

Add a small light on profile picture when a user's logged.

Once he leave the app, remove it.

Ingredients are now storred into every pizzas.

Instead of that, just keep an array of ingredientsIds.

Some ideas of improvement :

• Theme
• Responsiveness
• Logo

#30 should be done before that

Hi, my name is Ksenia. I'm a graphic designer and I'd like to collaborate on your open source project and propose free logo design for your project. If it's something you're interested in, please, let me know!

Best regards,
Ksenia

E2E tests are definitely missing here and I ended up breaking the export as CSV function after a library update which removes an rxjs operator I was using...

Cypress seems to be the perfect replacement for protractor and Pizza-Sync seems to be an excellent playground to play around!

Terrific sample project, by the way.

According to https://material.angular.io/guide/theming

The theme file should not be imported into other SCSS files. This will cause duplicate styles to be written into your CSS output. If you want to consume the theme definition object (e.g., $candy-app-theme) in other SCSS files, then the definition of the theme object should be broken into its own file, separate from the inclusion of the mat-core and angular-material-theme mixins.

I'm (very) new to scss and Angular Material, so I may be miss-interpreting this, but where you
@import '../../styles/shared/_colors';

eg in features.component.scss
isn't this doing just what the above tells us not to do, as mat-core is included in _colors.scss?

Please add a license file to the repo

When it's finally time to call the pizzeria and order some 🍕 🍕 🍕, it could be nice to have the phone number displayed somewhere (footer ?).

Same for the website, just in case :)

To avoid having build problem with node sass when using latest (currently node 10)

I've been using Prettier for months and I can't continue without a consistent format anymore on this project!

Those Pizzas needs some formatting 👍

Allow to edit the current userName if mistyping.

Pizza de l'Ormeau has awesome pizzas but we should be able to choose a different pizza provider.

Create a pizzas-providers folder were people can create other providers.

The app still have the angular logo displayed in the tab.

This logo should be removed and replaced by the pizza logo.

On the pizza provider "ormeau", the pizza "Poire Williams / chocolat" is giving poire-williams / chocolat instead of poire-williams-chocolat.

Instead of setting the provider directly in the code, we should ask the user when launching the backend which pizzas provider he wants to use for the session.

Would be nice to use Vorpal.

Related to #4.

I've been keeping an eye on NestJs for few months and it seems to be really amazing.

Typescript, decorators, on top of express, websocket integration, syntax similar to Angular... Pizza-Sync seems to be the perfect candidate for a first app with NestJs!

Steps to reproduce:

• be unlogged
• load pizza-sync web page in your browser
• before login box appears, click on pizza (any one)

The pizza img appears, maximized, but never, never you will see the login box again.
You need to reload to log.