maxlazar / mx-calculator Goto Github PK

I don't think the parameters work on EE 6. Tested several of them and they don't seem to do anything.

I can use mx-calc with php 7.4, but with php 8 I get following error:
Deprecated
preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated

user/addons/mx_calc/libraries/evalmath.class.php, line 330

I tried in vain to get in touch with Max Lazar.
Any solutions, anybody?

I would like to request some features:

• use variables (template variables, template partials, low variables) & exp:tags (like stash) as number values to do calculations on
  • eg: {exp:mx_calc expression="{grid_field:numbers_column} * {template_variable} + {exp:stash:get:value} / {template_partial}"} where the variables are numeric values
• support parse='inward' for above example
• be able to set the number of decimals
  • eg via a parameter: decimals='2'
• be able to force decimals if round number
  • eg via parameter: force_zeros='yes'
• set decimals separator: decimal_seperator=','
• set thousands separator: thousand_seperator='.'

Hey Max,

Thanks for the excellent add-on! I've used this in many of my EE installs and I'm really glad it exists.

I'm using this add-on on a site with EE 3.4.3 on a PHP 7 server.

I'm getting this PHP warning on any template I use the add-on:

Deprecated
Methods with the same name as their class will not be constructors in a future version of PHP; EvalMath has a deprecated constructor
user/addons/mx_calc/libraries/evalmath.class.php, line 88
Severity: E_DEPRECATED

More info can be seen here: http://php.net/manual/en/migration70.deprecated.php

I can only see this when logged in as admin in the EE control panel because EE is configured to suppress PHP warnings for non-super admins.

I replaced the constructor with this. I'm not sure if anything else relies on the constructor method, i.e. $this->EvalMath(), so I wanted backwards compatibility:

    public function __construct() {
    }

    public function EvalMath() {
        self::__construct();
    }

I'll try making a merge request soon.