mayhewsw / bibtex-js Goto Github PK

The regular expression used to filter out.  The preamble can contain ???? like 
shown below:

@misc{publisher_hrsc_????,
    title = {{HRSC} Data Browser},
    author = {publisher}
}



This was my solution:

  this.key = function() {
    var start = this.pos;
    while(true) {
      if (this.pos == this.input.length) {
        throw "Runaway key";
      }

      if (this.input[this.pos].match("[a-zA-Z0-9_:?\\./-]")) {
        this.pos++
      } else {
        return this.input.substring(start, this.pos).toUpperCase();
      }
    }
  }

What steps will reproduce the problem?

Copy This Bibtex entry in the online web converter

@article{D'Souza2010,
author = {D'Souza, Neil S and Lopes, Luiz A.C. and Liu, XueJun},
doi = {10.1016/j.epsr.2009.09.012},
file = {:C$\backslash$:/Users/z/Documents/Mendeley Desktop/D'Souza, Lopes, Liu 
- 2010 - Comparative study of variable size perturbation and observation 
maximum power point trackers for PV systems.pdf:pdf},
issn = {03787796},
journal = {Electric Power Systems Research},
keywords = {MPPT,Maximum Power Point Tracking,Photovoltaics},
mendeley-tags = {MPPT,Maximum Power Point Tracking,Photovoltaics},
month = mar,
number = {3},
pages = {296--305},
title = {{Comparative study of variable size perturbation and observation 
maximum power point trackers for PV systems}},
url = {http://linkinghub.elsevier.com/retrieve/pii/S0378779609002235},
volume = {80},
year = {2010}
}

What is the expected output? What do you see instead?
The expected output is a rendered HTML code. Instead I see an error message, 
mentioned below

Token mismatch, expected ,, found 'Souza2010, author = {D'Souza, Neil S and 
Lopes, Luiz A.C. and Liu...

What version of the product are you using? On what operating system?
Windows 7, Firefox 18

Please provide any additional information below.

It does not display special characters. Onta{\~n}{\'o}n should be displayed as 
Ontañón. Here is a list of special characters: 
https://github.com/okfn/bibserver/blob/master/parserscrapers_plugins/bibtex.py

p.s. will you move the project somewhere else now that Google is sunsetting 
code?

Just an idea: Could you extend your demo in a way that it accepts URLs that 
point to bib files?
Many people have bib files on github, like this one:
https://github.com/CoolProp/CoolProp/blob/master/CoolPropBibTeXLibrary.bib
Reading them would become so much more comfortable if they were rendered more 
nicely.

First off... Awesome job!

Bibtex if this form does not work correctly because of the , between the curly 
braces.  Zotero exports in this format.

@article{thing,
   ...
},

@article{something,
   ...
},

@inproceedings{name,
    ...
}



This is the fix I came up with

  this.bibtex = function() {
    while(this.tryMatch("@")) {
      var d = this.directive().toUpperCase();
      this.match("{");
      if (d == "@STRING") {
        this.string();
      } else if (d == "@PREAMBLE") {
        this.preamble();
      } else if (d == "@COMMENT") {
        this.comment();
      } else {
        this.entry(); 
      }
      this.match("}");
      if (this.tryMatch(",")){
          this.match(",");
      }

    }
  }


I added this line to the grammar  
string_end -> ( '' | ',' )


// Grammar implemented here:
//  bibtex -> (string | preamble | comment | entry)*;
//  string -> '@STRING' '{' key_equals_value '}' string_end;
//  string_end -> ( '' | ',' )
//  preamble -> '@PREAMBLE' '{' value '}';
//  comment -> '@COMMENT' '{' value '}';
//  entry -> '@' key '{' key ',' key_value_list '}';
//  key_value_list -> key_equals_value (',' key_equals_value)*;
//  key_equals_value -> key '=' value;
//  value -> value_quotes | value_braces | key;
//  value_quotes -> '"' .*? '"'; // not quite
//  value_braces -> '{' .*? '"'; // not quite

What steps will reproduce the problem?
1. Include a BibTeX entry with a '+' in the citation key
2. Attempt to generate page with citations


What is the expected output? What do you see instead?
Correctly formatted list of publications

What version of the product are you using? On what operating system?
Latest as of May 27, 2014

Please provide any additional information below.
Error happens at bibtex_js.js:57

What steps will reproduce the problem?
1. Place <span class="if publisher"><span class="publisher"></span>,</span> or 
<span class="if school"><span class="school"></span>,</span> in html

What is the expected output? What do you see instead? Only prints when a 
publisher exists, but always produces the ",".

Interesting enough, if neither are true it produces only one ","