maykinmedia / charts Goto Github PK

When a PR is made, check that helm lint succeeds. Otherwise block merging.

Not all charts need these vars:

{{/*
Worker labels
*/}}
{{- define "<name>.workerLabels" -}}
{{ include "<name>.commonLabels" . }}
{{ include "<name>.workerSelectorLabels" . }}
{{- end }}

{{/*
Worker selector labels
*/}}
{{- define "<name>.workerSelectorLabels" -}}
app.kubernetes.io/name: {{ include "<name>.workerName" . }}
{{- end }}

We should check from which charts it can be removed.

In de repo's van Objects en Object types staan ook Helm charts, maar zijn al ouder. Welke kunnen we het beste gebruiken voor installatie bij SSC Enschede op Azure AKS?

(overigens fijn dat jullie Helm charts maken voor al deze componenten)

 default.conf: |
    # Rate limiting configuration - allow 1 request per second. 10m can track about 80000 clients.
    limit_req_zone $binary_remote_addr zone={{ include "openforms.fullname" . }}.{{ .Release.Namespace }}_discover:10m rate=1r/s;

Make it opt in, you might want to configure this at the infrastructure level (ingress / loadbalancer / etc).

There are now 2 (3 if you count ingress) places to configure max upload:

Application:

settings.maxFileUpload

nginx:

nginx.config.clientMaxBodySize

This is confusing, the default values are also not the same.

Change nginx config to opt in.