Giter VIP home page Giter VIP logo

Comments (6)

mdbassit avatar mdbassit commented on July 22, 2024 1

Indeed, role="presentation" is the same as role="none", so it shouldn't be applied to interactive elements.

I think for now we can safely ignore the warning from FastPass. I'm more concerned with how screen readers treat the UI elements than with strictly complying with the standards. I'm open to any suggestions to improve compliance though.

from coloris.

mdbassit avatar mdbassit commented on July 22, 2024

I did consider what ARIA role to add and I couldn't find anything that fits. There is an open issue related to this on the ARIA Github repo that I've been watching for a while now (w3c/aria#432).

I haven't actually tested the impact of adding role="presentation" to #clr-color-marker on the popular screen readers (JAWS, VoiceOver, NVDA, ...). If you are willing to test it to make sure it doesn't have any negative impact on usability, I'll happily add the role.

from coloris.

jepsar avatar jepsar commented on July 22, 2024

@melloware Maybe we can ask @christophs78 to test the change.

from coloris.

melloware avatar melloware commented on July 22, 2024

@mdbassit you are right role="presentation" is not correct as the docs say

Note: The element with role="presentation" is not part of the accessibility tree and should not have an accessible name. Do not use aria-labelledby or aria-label.

from coloris.

melloware avatar melloware commented on July 22, 2024

Agreed should we leave this open for tracking and so no one else re-reports it?

from coloris.

mdbassit avatar mdbassit commented on July 22, 2024

Alright, let's leave it open for now

from coloris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.