Comments (9)
When you say an instance, do you mean a specific input field or a group of fields that use the same Coloris instance?
from coloris.
Its the specific input I am trying to set the color for or "instance"
Coloris.setColor(newColor, input[0]);
from coloris.
Here is what I really do so it works for popup mode or inline mode.
/**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
Coloris.setColor(newColor, input[0]);
},
from coloris.
Coloris.setColor(newColor, input[0]);
I think a better and more efficient way is to just set the value of the target fields directly and then trigger an input
(or change
for #clr-color-value
) event. You can replace the Coloris.setColor() method with this:
function setColor(color, target) {
const colorValue = document.querySelector('#clr-color-value');
// Color fields listen for an "input" events while the color value field
// within the picker listens for a "change" event
const event = target === colorValue ? 'change' : 'input';
target.value = color;
target.dispatchEvent(new Event(event, { bubbles: true }));
}
from coloris.
Here is what I really do so it works for popup mode or inline mode.
Or even better, here is a rewrite of your code above:
/**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
var event = this.popup ? 'input' : 'change';
var target = input[0];
target.value = color;
target.dispatchEvent(new Event(event, { bubbles: true }));
},
from coloris.
This is pretty close. The only difference is with mine because our wrapper send AJAX events on change of color I need the change event fired for either popup or inline and your input
method does not fire the change.
This was vital for us so the change event fires for inline or popup and ONLY fires if the color actually changes.
if (oldColor !== color) {
currentEl.dispatchEvent(new Event('change', { bubbles: true }));
}
from coloris.
How about this:
/**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
var target = input[0];
var oldColor = target.value.toLowerCase();
var triggerInputEvent = !!this.popup;
if (color.toLowerCase() !== oldColor) {
target.value = color;
triggerInputEvent && target.dispatchEvent(new Event('input', { bubbles: true }));
target.dispatchEvent(new Event('change', { bubbles: true }));
}
},
from coloris.
This seems to work!
from coloris.
Should I close this then?
from coloris.
Related Issues (20)
- When used in modal dialog-tag, color picker is displayed behind the modal HOT 5
- close dialog box with keyboard HOT 1
- No way to access the current element? HOT 2
- Manually clearing color has unexpected behavior HOT 3
- Enhancement: mirror cursor position/selection when picker is opened with focusInput: true HOT 4
- Allow el configuration property to be the dom element HOT 4
- How do you add a custom input?
- Dragging hue and alpha markers doesn't work on iOS HOT 4
- Reading option with attributes HOT 1
- How to programmatically change the thumbnail color?
- 能增加一个onClose事件监听吗? HOT 1
- Firefox accessing colorAreaDims before initialization HOT 18
- NaN values when inline color picker HOT 7
- Open method HOT 3
- clr-open-label not initialized on osX HOT 4
- Feature Request: Pipette / Eye Dropper HOT 2
- custom element HOT 4
- Display Value color after refresh page HOT 1
- passive event handler HOT 11
- mousemove event not removed when i release mouse on iFrame HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coloris.