Giter VIP home page Giter VIP logo

Comments (9)

mdbassit avatar mdbassit commented on June 20, 2024

When you say an instance, do you mean a specific input field or a group of fields that use the same Coloris instance?

from coloris.

melloware avatar melloware commented on June 20, 2024

Its the specific input I am trying to set the color for or "instance"

Coloris.setColor(newColor, input[0]);

from coloris.

melloware avatar melloware commented on June 20, 2024

Here is what I really do so it works for popup mode or inline mode.

/**
      * Sets the current color
      * @param {string} color the color to set
      */
    setColor: function(color) {
        if (!color) {
            return;
        }
        var newColor = color.toLowerCase();
        var input = this.popup ? this.input : this.jq.find('#clr-color-value');
        Coloris.setColor(newColor, input[0]);
    },

from coloris.

mdbassit avatar mdbassit commented on June 20, 2024
Coloris.setColor(newColor, input[0]);

I think a better and more efficient way is to just set the value of the target fields directly and then trigger an input (or change for #clr-color-value) event. You can replace the Coloris.setColor() method with this:

function setColor(color, target) {
  const colorValue = document.querySelector('#clr-color-value');
  // Color fields listen for an "input" events while the color value field
  // within the picker listens for a "change" event
  const event = target === colorValue ? 'change' : 'input';

  target.value = color;
  target.dispatchEvent(new Event(event, { bubbles: true }));
}

from coloris.

mdbassit avatar mdbassit commented on June 20, 2024

Here is what I really do so it works for popup mode or inline mode.

Or even better, here is a rewrite of your code above:

/**
  * Sets the current color
  * @param {string} color the color to set
  */
setColor: function(color) {
    if (!color) {
        return;
    }

    var newColor = color.toLowerCase();
    var input = this.popup ? this.input : this.jq.find('#clr-color-value');
    var event = this.popup ? 'input' : 'change';
    var target = input[0];
    
    target.value = color;
    target.dispatchEvent(new Event(event, { bubbles: true }));
},

from coloris.

melloware avatar melloware commented on June 20, 2024

This is pretty close. The only difference is with mine because our wrapper send AJAX events on change of color I need the change event fired for either popup or inline and your input method does not fire the change.

This was vital for us so the change event fires for inline or popup and ONLY fires if the color actually changes.

if (oldColor !== color) {
       currentEl.dispatchEvent(new Event('change', { bubbles: true }));
    }

from coloris.

mdbassit avatar mdbassit commented on June 20, 2024

How about this:

/**
  * Sets the current color
  * @param {string} color the color to set
  */
setColor: function(color) {
    if (!color) {
        return;
    }

    var newColor = color.toLowerCase();
    var input = this.popup ? this.input : this.jq.find('#clr-color-value');
    var target = input[0];
    var oldColor = target.value.toLowerCase();
    var triggerInputEvent = !!this.popup;
    
    if (color.toLowerCase() !== oldColor) {
        target.value = color;
        triggerInputEvent && target.dispatchEvent(new Event('input', { bubbles: true }));
        target.dispatchEvent(new Event('change', { bubbles: true }));
    }
},

from coloris.

melloware avatar melloware commented on June 20, 2024

This seems to work!

from coloris.

mdbassit avatar mdbassit commented on June 20, 2024

Should I close this then?

from coloris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.