mdolidon / endlines Goto Github PK

When I try to compile on a AIX box I get
"walkers.c", line 210.25: 1506-022 (S) "d_type" is not a member of "struct dirent".

I manage to fix this by following http://stackoverflow.com/questions/2197918/cross-platform-way-of-testing-whether-a-file-is-a-directory

I think this will help others, when trying to compile on multiple platforms.

BTW done a good job on the project and I love it

Hi!

Congratulation, it's really an useful tools! 👍 👍 👍
Can you plan to add a flag in order to specify list of directories to exclude?

$ endlines --exclude ./subdir1,/home/mdolidon/projects/ednlines/build,./subdir2

-x / --exclude            : doesn´t process sub-directories.

Thank's a lot.

Here's a project outline I have in mind. Will submit pull requests. Let me know what you think, and we can edit this outline.

• Use install command within makefile install target
• Provide feedback within makefile install and uninstall targets
• Move help to man file
• Create AUR package
  • https://aur.archlinux.org/packages/endlines
• Create Ubuntu package
• Create brew package
• GitHub Actions CI/CD to deploy to package repositories on release
• Remove binaries from repository
  • Compile time of endlines is almost instant. I see no benefit of providing a binary. If you wish to still provide a binary, it could be compiled within a GitHub action and stored as an artifact.

Reviewing the pre-conversion check function, it seems that if :

• the file is already in the target convention
• it does not have a final EOL
• a final EOL is requested by the user
  the check may lead to that file being skipped.

To do : test and fix.

Thank you for writing such a great tool! Everything works like expected. Keep it up!

Is there any particular reason that output is written to STDERR and not STDOUT?

This gets broken:

$ endlines check -r -v . | less

Of course, this produces the expected result:

$ endlines check -r -v . 2>&1 | less

Also, on a side note, it is common to allow short flag collapsing, so I expected the below to also work:

$ endlines check -rv .

Would love to be able to install/update this with brew. Handy tool that should be spread far and wide.

I've not created a Homebrew Formula myself, which is why I'm not creating a PR ... but here's the Homebrew Formula Cookbook

Picking an example Formula at random 😀 , here's the Formula for dos2unix.

Thanks for the great tool. 👍

Can you add a note in README.md about whether Windows is supported?

Building on a mac:

Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I get:

cc -O3 -Wall -std=c99 -c src/file_operations.c -o src/file_operations.o
cc -O3 -Wall -std=c99 -c src/walkers.c -o src/walkers.o
cc -O3 -Wall -std=c99 -c src/convert_stream.c -o src/convert_stream.o
cc -O3 -Wall -std=c99 -c src/main.c -o src/main.o
src/main.c:251:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
    clock_gettime(CLOCK_REALTIME, &res);
    ^
src/main.c:251:19: error: use of undeclared identifier 'CLOCK_REALTIME'
    clock_gettime(CLOCK_REALTIME, &res);
                  ^
1 warning and 1 error generated.
make: *** [src/main.o] Error 1

Originally posted by @uuencode

I was unsure if I had to open a new issue. It compiled without errors. When I try to convert a file in a directory it says:

endlines linux -r /mnt/DATA/test
endlines : converting files to Unix (LF)
endlines : could not restore permissions for /mnt/DATA/test/aaa.txt
endlines : could not restore ownership for /mnt/DATA/test/aaa.txt

endlines : 1 file converted from :

• 1 Windows (CR-LF)

and the file is deleted. With "sudo" the result is the same.

Thank you in advance!

My answer :

That's a new one, and might actually be an unknown and worrysome bug. I'll look into it.
Could you please show me an extract of ls -l for mnt, DATA, test and aaa.txt, so that I can attempt to reproduce it in a similar situation ?

Hello! Absolutely great tool @mdolidon
I was hoping for a feature request, which I will gladly make a small condation for.

Lets be honest, most of us use this on Linux to find those pesky Windows CR-LF.
When I try and find files in verbose mode, it prints all the "LF" files, and theres a lot of them. I am really only looking for problematic CR-LF files.
So I was hoping for a less-verbose mode, that would only print

              - No line ending
              - Windows (CR-LF)
              - Mixed endings

And NOT print - Unix (LF)

An example output would be (what Im currently doing): grep -rIl -m 1 $'\r' which only finds the problematic files.

For more configuration, a toggle could be provided to choose between verbose (all) or verbose (some) and somehow choose which few line endings to scan for.

If "process hidden files" option is enabled, when a hidden directory is encountered by the walkers library, instead of recursing into it it sends the directory's name to the client code as a file to be processed.
Not anywhere near my dev station this week. Issue will be adressed before jan 23.

Thank you for your awesome tools.

I found some issue. It will freeze when found zero bytes file.

0.3.2 does not depend on dynamic memory allocation anymore. However buffered streams take up a total of 200Kb on the stack. Reduce buffer size to make sure the stack does not exceed 64Kb, to allow running this on OSes with very weak stacks (OpenBSD...). Suggestion : make buffer size be around 20 Kb.

I just ran this on some files. Most are just text files but one is a shell script. After the endlines run, I found that the shell script had had its permissions changed so that it was no longer executable. I ran chmod +x on it and it was fine again.

Running endlines recursively as "endlines -r linux *" in a directory containing a file named -prj.ipr (starts with a dash), resulted in the error "Unknown option -p".

Renaming the file solved the problem.

Sorry to be a pain. I have successfully used endlines with Ubuntu 14.04, now on 16.04 it cannot compile. Here's the result of "sudo make install"

cc -o endlines src/walkers.o src/engine.o src/main.o
src/main.o: In function convert_one_file': main.c:(.text+0xab5): undefined reference toengine_run'
src/main.o: In function check_one_file': main.c:(.text+0xcdd): undefined reference toengine_run'
src/main.o: In function main': main.c:(.text.startup+0xc9): undefined reference toengine_run'
collect2: error: ld returned 1 exit status
makefile:10: recipe for target 'endlines' failed
make: *** [endlines] Error 1

This tool looks really useful, but I can't use it if it doesn't compile :3.

$ sudo make install
cc -O3 -Wall -std=c99   -c -o src/walkers.o src/walkers.c
src/walkers.c: In function ‘walk_directory’:
src/walkers.c:203:35: error: ‘DT_DIR’ undeclared (first use in this function)
         } else if(pent->d_type == DT_DIR) {
                                   ^
src/walkers.c:203:35: note: each undeclared identifier is reported only once for each function it appears in
src/walkers.c:205:35: error: ‘DT_REG’ undeclared (first use in this function)
         } else if(pent->d_type == DT_REG) {
                                   ^
src/walkers.c:182:11: warning: variable ‘fake_filenames_array’ set but not used [-Wunused-but-set-variable]
     char* fake_filenames_array[1];              // this holder is a convenience
           ^
make: *** [src/walkers.o] Error 1

Did a hasty refactor this morning, and missed a necessary check on a return value.
TODO :

• main.c add return value check on open_streams
• add a test case for non-existent files, or files that can't be written on

Hey - any chance this will be available for install with yum / apt?

Its too good not to be...

Hi, here's a binary and the test_report_1.9.1.txt, compiled under 10.11.6 (15G1611) / XCode 8.2.1:
Archive.zip