Comments (12)
tsalo
commented on July 24, 2024
1
Sounds good to me. We'll use a GitHub Action that mimics tedana's approach then. I want to hold off on actually making any releases until we're sure about not merging into sklearn or nilearn though.
from mapca.
notZaki
commented on July 24, 2024
1
I think adding long_description_content_type='text/markdown' into setup.py might fix the readme? That's what tedana has anyways.
EDIT: Just made a pypi account: notzaki
from mapca.
tsalo
commented on July 24, 2024
I'm fine using auto or the deploy GitHub Action (which should operate similarly to how we currently have tedana set up), but if we go with auto then someone else will have to set it up.
from mapca.
eurunuela
commented on July 24, 2024
I think the "tedana approach" is easier, but I could try to set up auto if you like it better.
from mapca.
tsalo
commented on July 24, 2024
Now that #36 has been merged, I think we can release. We will need to deploy the first release manually, I think, based on recent experience with rapidtide. I can do that this week if we're all happy with things.
from mapca.
eurunuela
commented on July 24, 2024
I'm happy with things. I say we deploy. Wbu @notZaki ?
from mapca.
notZaki
commented on July 24, 2024
Sounds good to me.
GPL might be an obstacle for this being useful for tedana, but that can be tackled later.
from mapca.
tsalo
commented on July 24, 2024
Awesome! I just noticed a couple of small things in the pyproject.toml file, so I'll try to clean up the distribution files in a final PR, and then we can release 0.0.1!
from mapca.
tsalo
commented on July 24, 2024
I'm getting an error with python -m build:
Traceback (most recent call last):
File "/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 280, in <module>
main()
File "/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 263, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 204, in build_wheel
return _build_backend().build_wheel(wheel_directory, config_settings,
File "/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/build-env-ek0k7r0e/lib/python3.8/site-packages/setuptools/build_meta.py", line 176, in build_wheel
shutil.copytree('dist', wheel_directory)
File "/opt/miniconda3/lib/python3.8/shutil.py", line 552, in copytree
with os.scandir(src) as itr:
FileNotFoundError: [Errno 2] No such file or directory: 'dist'
Traceback (most recent call last):
File "/opt/miniconda3/lib/python3.8/subprocess.py", line 364, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/build-env-ek0k7r0e/bin/python', '/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py', 'build_wheel', '/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/tmpxbgdolqp']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/miniconda3/lib/python3.8/site-packages/build/__init__.py", line 309, in _call_backend
raise BuildBackendException(exception)
build.BuildBackendException: Backend operation failed: CalledProcessError(1, ['/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/build-env-ek0k7r0e/bin/python', '/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py', 'build_wheel', '/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/tmpxbgdolqp'])
ERROR Backend operation failed: CalledProcessError(1, ['/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/build-env-ek0k7r0e/bin/python', '/opt/miniconda3/lib/python3.8/site-packages/pep517/in_process/_in_process.py', 'build_wheel', '/var/folders/ph/w3cbhj9n16s9bx4l7gq3dq6m0000gn/T/tmpxbgdolqp'])from mapca.
tsalo
commented on July 24, 2024
Okay, wait a second... it looks like it deployed when I made the rc release! So yay! 🎉
But also the README doesn't render correctly on the website because it's MarkDown I guess. I know that came up somewhere recently but I can't remember where exactly.
EDIT: I want to add you both to the project on PyPi. Do you have PyPi usernames?
from mapca.
eurunuela
commented on July 24, 2024
Thanks @tsalo ! I'm eurunuela on pypi. I'll have a look at the README tomorrow if you still haven't figured it out.
from mapca.
tsalo
commented on July 24, 2024
I'm eurunuela on pypi.
Thanks!
I'll have a look at the README tomorrow if you still haven't figured it out.
It's all good now. We also have 0.0.1, so I'm going to close this issue.
from mapca.
Related Issues (20)
- Set up continuous integration HOT 7
- Codecov not working
- [BUG] Dimensions of masked data not considered for fit_transform HOT 3
- Replacing utils._kurtn with scipy.stats.kurtosis HOT 5
- maPCA in tedana does not currently z-score data before performing PCA HOT 3
- Cite original maPCA paper and GIFT package
- Make class accept images instead of arrays HOT 3
- Scaler parameters overridden within MovingAveragePCA HOT 2
- Operate on images in subsampling function HOT 3
- Use nilearn's masking/unmasking functions internally
- Zenodo release
- Remove commented code
- Documentation missing HOT 4
- Tests fail due to make command not being installed
- Document typical results for different datasets/acquisition parameters HOT 1
- Remove DueCredit dependency
- Identified part of the issue with component misestimation
- `n_features_` from sklearn's PCA is deprecated
- Update package installation and minimum Python version
- Black and isort need to be rerun
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapca.