Giter VIP home page Giter VIP logo

mediamod's People

Contributors

caoimhebyrne avatar djtheredstoner avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

mediamod's Issues

Execution failed for task ':reobfJar'. > java.util.zip.ZipException: duplicate entry: META-INF/DEPENDENCIES

This is my first time trying to compile a mod and after using --stacktrace, I still don't understand how to fix this.

Below is the output from trying to compile the mod:

C:\Users\Sukarodo\Downloads\MediaMod-master>gradlew.bat build --stacktrace
> Task :reobfJar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':reobfJar'.
> java.util.zip.ZipException: duplicate entry: META-INF/DEPENDENCIES

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':reobfJar'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
        at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
        at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
        at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.run(EventFiringTaskExecuter.java:51)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:317)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:309)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:185)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:97)
        at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:46)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$ExecuteTaskAction.execute(DefaultTaskExecutionGraph.java:262)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$ExecuteTaskAction.execute(DefaultTaskExecutionGraph.java:246)
        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:136)
        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:130)
        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.execute(DefaultTaskPlanExecutor.java:201)
        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.executeWithTask(DefaultTaskPlanExecutor.java:192)
        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:130)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
Caused by: org.gradle.api.UncheckedIOException: java.util.zip.ZipException: duplicate entry: META-INF/DEPENDENCIES
        at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:57)
        at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:40)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:76)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:46)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:39)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:26)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:794)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:761)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:131)        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:317)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:309)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:185)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:97)
        at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:120)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:99)
        ... 30 more
Caused by: java.util.zip.ZipException: duplicate entry: META-INF/DEPENDENCIES
        at net.minecraftforge.gradle.user.TaskSingleReobf.applyExtraTransformers(TaskSingleReobf.java:253)
        at net.minecraftforge.gradle.user.TaskSingleReobf.doTask(TaskSingleReobf.java:184)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
        ... 43 more


* Get more help at https://help.gradle.org

BUILD FAILED in 4s
11 actionable tasks: 4 executed, 7 up-to-date

INVALID_CLIENT: Invalid client

Describe the bug
"INVALID_CLIENT: Invalid client" when trying to connect the mod to Spotify.

To Reproduce
Steps to reproduce the behavior:

  1. Log onto any Minecraft server.
  2. Execute the command "/mm"
  3. Click on "Services".
  4. Click on "Login to Spotify".
  5. The website you are brought to should give you the error.

Expected behavior
I expected to see some sort of login or verification page to Spotify

Screenshots
Screenshot of error: https://imgur.com/a/lVjnlsa

Operating System
I am using Linux.

Service causing this bug, if applicable
I was using Spotify.

Additional context
I tried using Chrome and Firefox, same error.

Player not showing up

Describe the bug.
if Spotify music isn't started before launching minecraft the player wont show up and cant be toggled on unless you restart your game with music already playing.(atleset i think that thats the issue)
To Reproduce
Steps to reproduce the behavior:

  1. launche the minecraft without music playing already

Expected behavior
the player should show up anytime you start the music and it did so in v1.0 but it dosnt anymore.(this bug has been around since v1.1 realese but i frogot to report it/didnt know what caused it)

Screenshots
i dont have a screenshot but theres realy nothing to show all the setttings are how thay are suppose to be

Operating System
Windows 10

Service causing this bug, if applicable
Spotify

Additional context
If you have any other questions ask them.

How to install and use?

Ok look sorry I'm an idiot but how tf do I use this there's no .jar anywhere and there are no tutorials. It's not on the curseforge or anything :/ The discord invite isn't working either. I've tried everything I know how to do but nothing works. my discord is Goblin#6169 if you would like to help.

ERROR: Failed to login to Spotify

ERROR: Failed to login to Spotify!
I keep trying to login to Spotify but the ERROR: Failed to login to Spotify! message keeps showing up. I tried restarting, moving the mod back in the mod folder but nothing works! Should I just wait for the next update or how do I fix it? Is it my that I have other mods? I'm using the MediaMod-1.2.4.

Steps to reproduce the behavior:

  1. Press M
  2. Click on Services
  3. Click "Login to Spotify"
  4. See error

A clear and concise description of what you expected to happen.
Login to Spotify

What OS are you on? (Windows, macOS, Linux)
Windows

What service were you using when the bug occurred? (Spotify, YouTube, SoundCloud, etc.)
Spotify and Minecraft

access control allow origin

Describe the issue
Due to setting the Access-Control-Allow-Origin header in BrowserHandler.java to *, any website can use JavaScript to set the song that's playing. This is insecure

To exploit this security issue
Steps to exploit the issue:

  1. Enable browser handler
  2. Go to https://cubxity.dev/conor.html

Operating System
N/A

Themes

Im building from latest commit and wondering how to change themes? i made my own but i only see the default ones. Thank you!

Crash when I try load "Player Settings"

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'MediaMod Settings'
  2. Click on 'Player Settings'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.
I expected to see the menu for the player but received a crash with a NPE

Screenshots
If applicable, add screenshots to help explain your problem.

Operating System
What OS are you on? (Windows, macOS, Linux)
Windows

Service causing this bug, if applicable
What service were you using when the bug occurred? (Spotify, YouTube, SoundCloud, etc.)
N/A

Additional context
Add any other context about the problem here.

java.lang.NullPointerException: Rendering screen
	at me.conorthedev.mediamod.gui.PlayerOverlay.drawPlayer(PlayerOverlay.java:247)
	at me.conorthedev.mediamod.gui.GuiPlayerSettings.func_73863_a(GuiPlayerSettings.java:55)
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:309)
	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1103)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1051)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:349)
	at net.minecraft.client.main.Main.main(SourceFile:124)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
	at me.conorthedev.mediamod.gui.PlayerOverlay.drawPlayer(PlayerOverlay.java:247)
	at me.conorthedev.mediamod.gui.GuiPlayerSettings.func_73863_a(GuiPlayerSettings.java:55)
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:309)

MediaMod Gui Keybind

Is your feature request related to a problem? Please describe.
Add a keybind to open the Gui

Describe the solution you'd like
Add a keybind in Controls

Describe alternatives you've considered
Add a settings menu in options (like Shaders menu with optifine)

Foobar2000 Support

Is your feature request related to a problem? Please describe.
It not

Describe the solution you'd like
I would like Support for the Music Player Foobar2000, the same way As Spotify is right now

Describe alternatives you've considered
Well the same as in Spotify :D

Additional context
Nope

Incorrectly formatted JSON data causes crash

Describe the bug
When the browser handler receives a status update without any images, it'll still accept it and set the currently playing object. This causes an ArrayIndexOutOfBoundsException when rendering the player. If album art rendering is turned off, this doesn't happen, but the same issue occurs when no artists are found.
This is an issue because people could write malicious code that crashes your client as soon as it launches without you knowing.

To Reproduce

  1. Launch the client and make sure the browser handler is enabled and ready.
  2. Join a world or server to make sure that the player will render.
  3. Send track JSON data without any image or artist data, for example:
{
    "progress_ms":0,
    "item":{
        "duration_ms":0,
        "name":"Client Crasher",
        "album":{
            "artists":[

            ],
            "images":[

            ]
        }
    }
}
  1. The client crashes while rendering

Expected behavior
The client refuses to render the malformed data or doesn't render any album art or artist text.

Screenshots
N/A

Operating System
Windows

Service causing this bug, if applicable
N/A

Additional context
None

Translations bug

Describe the bug
Translations aren't fully working

To Reproduce
Steps to reproduce the behavior:

  1. Use last github build
  2. Go in MediaMod gui

Expected behavior
Translations

Screenshots
image
image

Service causing this bug, if applicable
What service were you using when the bug occurred? (Spotify, YouTube, SoundCloud, etc.)

Additional context
As translations are not using the same space they exceed.

Resume/Skip

Hello resuming/pausing and skipping does not work for me, ive tried changing the keybinds and everything! please help

Could be a bug

Describe the bug
Player doesn't show up and console is spammed.

To Reproduce
Steps to reproduce the behavior:

  1. Build the last github version
  2. Start a new world

Console
[18:29:48] [pool-9-thread-1/INFO] [STDERR]: [me.conorthedev.mediamod.media.spotify.SpotifyHandler:getCurrentTrack:201]: at java.util.concurrent.FutureTask.runAndReset(Unknown Source)

Operating System
Windows 10
Minecraft 1.8.9
Forge 11.15.1.1722

Media Mod does not detect songs and also displays time incorrectly

So a lot of the time the media mod does not detect the music playing on Youtube Music, when it DOES detect it it adds 30mins to each side so if it is actually at 1:15/2:15 it would show 31:15/32:15

Steps to reproduce the behavior:
Simply install the mod with latest version of forge on MC 1.8.9

I expected it to simply pick up the songs from music.youtube.com and show me a player in the top left with the correct time, lately it hasn't been detecting the songs and when it does detect them it shows wrong time

I would add screenshots but I cannot as it hasn't shown me the player

Doesn't work on Windows or Linux for me

I was using Youtube Music as stated above

MediaMod API refuses to connect even after multiple restarts

Describe the bug
MediaMod API refuses to connect even after multiple restarts

To Reproduce
Steps to reproduce the behavior:

  1. Do /mm
  2. Click on 'services'
  3. Scroll down to 'reconnect'
  4. See how it will say "Failed to connect to MediaMod API!"

Expected behavior
I expected it to have something along the lines of "Success!"
2020-10-06_19 17 49

Screenshots
Look at bottom left of attached screenshot.

Operating System
macOS

Service causing this bug, if applicable
Soundcloud and YouTube

Additional context
Add any other context about the problem here.

Progress Bar

Is your feature request related to a problem? Please describe.
Progress bar is only progressing by 3 in 3 seconds

Describe the solution you'd like
It should progress more harmoniously.

Describe alternatives you've considered
Reduce the time it takes to refresh.

Additional context
It's doing that with soundcloud and youtube (did not test with other services)

Have to re log every time the game launches

first congratulations for this mod,
then, idk if it's supposed to work like that but if it isn't a bug maybe a thing that make you staying connected between minecraft sessions will be cool

edit: i'm a linux user, not very sure if it's changing something

Song not showing up

After using it for a few days the player doesn't show while playing song. I tried to re-connect Spotify but nothing. I tried to reinstall but that did nothing.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.