Giter VIP home page Giter VIP logo

Comments (7)

ulnasensei avatar ulnasensei commented on May 30, 2024 3

The room IDs are just randomly generated alphanumeric strings. AFAIK there is no character limit for the announce URL, it's just the generator is using 16 char length. You can use whatever you want as the room ID and it will just work they are not stored anywhere, and there is no server-side room ID validation. The server just connects peers that use the same room ID.

https://github.com/meehow/privtracker/blob/master/docs/index.html

function makeRoom(length) {
			var roomID = '';
			var characters = 'abcdefghijklmnopqrstuvwxyz0123456789';
			var charactersLength = characters.length;
			for (var i = 0; i < length; i++) {
				roomID += characters.charAt(Math.floor(Math.random() * charactersLength));
			}
			var urls = document.getElementsByClassName('url');
			for (var i = 0; i < urls.length; i++) {
				urls[i].innerText = urls[i].innerText.replace('{{room}}', roomID);
			}

			document.getElementById('hidden').style.display = 'block';
		}

from privtracker.

SinTan1729 avatar SinTan1729 commented on May 30, 2024 2

It's been about a month without anyone else opening a PR, so I decided to do it.

from privtracker.

Pentaphon avatar Pentaphon commented on May 30, 2024

You can use whatever you want as the room ID and it will just work they are not stored anywhere, and there is no server-side room ID validation. The server just connects peers that use the same room ID.

Then there should be some kind of notice or function on the website that lets people know this that so they can enhance their privacy by using their own random number generator to create any size room ID they want. Maybe also a drop-down list to let people select how long they want their room ID to be. Right now it's a little too basic.

from privtracker.

meehow avatar meehow commented on May 30, 2024

16 characters from 36 character set, that's 7958661109946400884391936 combinations. If someone will manage to make 1000 requests to the server per seconds it will take 7958661109946400884391936/1000/3600/24/365 = 252367488265677 years to brute force it. And you need to repeat it for every file (info hash) you are looking for.

from privtracker.

Pentaphon avatar Pentaphon commented on May 30, 2024

16 characters from 36 character set, that's 7958661109946400884391936 combinations. If someone will manage to make 1000 requests to the server per seconds it will take 7958661109946400884391936/1000/3600/24/365 = 252367488265677 years to brute force it. And you need to repeat it for every file (info hash) you are looking for.

I still think real private trackers use 32 character passkeys for a reason and following suit seems reasonable. There's no reason not to.

from privtracker.

meehow avatar meehow commented on May 30, 2024

There's no reason not to.

Agreed. Feel free to open a pull request.

from privtracker.

meehow avatar meehow commented on May 30, 2024

thanks, merged

from privtracker.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.