megaqwertification / stadiumbot Goto Github PK

convert to frames or something. right now there's no error checking if a time is valid

• check if score is valid before adding to database
• if not valid, check if debug is true. if it is, check if that's valid
• otherwise reject the score addition to the database

if comparing if debug time is > or < some value, convert to frames

• current formula should do this but has not been tested

Will have to fill player database and make some sort of alias matching,

Decide the limit it would take to consider a WR as "many" tied. May vary per mode

Notable examples:
E17 - "many"
HRC Ganon & ICs

see if this is an interactions error

Make sure it doesn't add to frame count

Should be quick to modify the database, but many files (import scripts, add commands, etc. need to be edited)

https://interactions-py.github.io/interactions.py/Guides/98%20Migration%20from%204.X/#slash-commands

https://code.visualstudio.com/docs/editor/codebasics#:~:text=Search%20across%20files,each%20file%20and%20its%20location.

or if a record ties

similar functionality to mmbot

See mm history spreadsheet + to do list

longer work time (1 month +)

/app/commands/btt_commands.py:142> exception=AttributeError("'list' object has no attribute 'close'")>
2023-01-03T05:52:08.157893+00:00 app[worker.1]: Traceback (most recent call last):
2023-01-03T05:52:08.157894+00:00 app[worker.1]: File "/app/commands/btt_commands.py", line 278, in _btt_wr_list
2023-01-03T05:52:08.157894+00:00 app[worker.1]: cur.close()
2023-01-03T05:52:08.157895+00:00 app[worker.1]: AttributeError: 'list' object has no attribute 'close'

Does not cause the bot to break but really should clean this up

if a run exists and you just want to update a field (eg. tags) you should find a way

Requires testing filtering

Test runs:
/add-btt-record character: Yoshi stage: yoshi player: Cybe score: 1.53 sources: https://www.youtube.com/watch?v=qGgtHPnPgOc date: 2010-01-01 emulator: false tags: BSS ver: PAL
/add-btt-record character: mario stage: mario player: Cybe score: 1.11 sources: https://www.youtube.com/watch?v=qGgtHPnPgOc&t=6s date: 2010-01-01 emulator: false tags: BSS ver: PAL

event-wr-list command with TAS flag should show the RTA run if both the TAS and RTA exist but RTA beats the TAS

May apply to other modes as well

investigate old documents like treklink's document

should be vetted more by people who have played those modes

Cannot risk any errors in player names but shouldn't be too hard to make

Kavaz's event 25 unrecorded WR of 3.67 has gone uncontested for many years without proof.

TODO

• find forum sources for kavaz claiming the record
• find forum sources documenting the WR in their list
• consult players like vikingja, Samplay, SN, SW, Emperor, Infernum, and anyone from the older days about the legitimacy of the WR
• conduct a vote to see if the run should be removed from the leaderboard. Remove the run if the vote agrees to remove

Some sort of cronjob that saves the last couple days, weeks of databases idk

shouldve also had my record

Determine a random char and/or stage pairing for the various modes and a relevant SuS tag

Return the relevant WR to beat or none if not existing.

Legacy runs (ajp 7.77 and before) may have used AR for coded items. Although the standard nowadays is to find an appropriate seed, the previous records did not do that but are still included by the community

So don't filter out these runs when running the history command. Code in an exception

HRC and events - need to see what to put in place for "many"

10MM -> should be doable

To be done in order to import thousands of runs

current schema keeps individual modes in their respective table

Need to decide on a better schema which can keep players in one table, other fields in their own table, etc.

because there's no video, it bugs out

Add-wr commands. should properly check if the wr exists in the db already

e.g. for mismatch ganon/doc '9' won't be a value. it might be enumerated as 9.00

Note this issue isn't for regular ties like E12 that have some missing sources

HRC - ganon and ICs all ties
Events - E17 and 32 all ties you can find.

This is for the event-wr and event-wr-list command

Many runs were mistakenly added to the db under the assumption of NTSC 1.02 without even thinking . Should compare run dates to release dates of different melee versions if you're uncertain.

Melee Dev runs pretty sure they were 1.00 but need to confirm

check if this is the case for anything else lol

Heroku is going to start charging for psql db instances, migration to supabase is a possibility, but should ideally paired with an overall db overhaul

Best total, worst total, stage total, etc.

should this technically be considered a previous TAS WR?

Ask the community

BtT commands do, maybe not all of them

I could see this bug coming up in jiggs/ganon if Jerry comes up instead of r1k

this can easily be mitigated (if it happens) by including timestamp along with the date but then would have to investigate properly

As per the sus sheet

https://docs.google.com/spreadsheets/d/1FoPc2XYOb8tmZi672QncfTvrFtbFmXbB/edit#gid=866654914