mehmetc / primo-explore-dom Goto Github PK

First, thanks for creating this – a very interesting project!

I installed the package using npm install primo-explore-dom --save-dev.

Since I'm using browserify, the package wasn't included automagically, so I tried adding a

require('primo-explore-dom/js/primo-explore-dom');

but when running gulp I got:

Error: Cannot find module '../../modules/core.regexp.escape' from '/path/to/primo-explore-devenv/primo-explore/custom/UIO/node_modules/primo-explore-dom/js'

When looking at the primo-explore-dom.js file, I notice that it indeed requires core-js and regenerator-runtime, but these are not declared in package.json. Should they?

Also, I don't really understand how custom.js is built, and where the ../../modules/core.regexp.escape path in custom.js:34 comes from. Notice that it uses "modules" rather than "node_modules" – rather weird. Perhaps you can add a "Contribute" or "Develop" section to the README where you document how to build this project?

Hi Mehmet,

I tried installing primo-explore-dom in my primo-explore-devenv. If I do npm ls it is listed as well as it is included in package.json.

But when I do a gulp run with my view, then in the browser angular.reloadWithDebugInfo(); and Primo.isDebugEnabled(), I get "ReferenceError: Primo is not defined" in the console.

I tried finding out whether more configuration was necessary for the package to be included when running gulp, but couldn't find a solution so far.

Best,
Gabriele

We're currently looking into a switch to Primo VE and would be interested if this library will work with VE?
It might not be dependent, but I wan't to make sure that there no caveats in using primo-explore-dom with VE…
Thank you,
Johannes

Hi @mehmetc ,

user.isOnCampus() works fine for me if I'm not logged in:

However, if I do login the Promise returns false, which is wrong:

I'm not sure if I've done something wrong with the installation? Can you help me out?

Best,
Johannes