adding users to project group directly fails about karaage HOT 5 OPEN

Don't understand why there is a DeprecationWarning here, think the code will work just fine if you delete the error condition.

diff --git a/karaage/people/models.py b/karaage/people/models.py
index dfdd856..3f7f9bc 100644
--- a/karaage/people/models.py
+++ b/karaage/people/models.py
@@ -723,12 +723,6 @@ class Group(models.Model):
     sync_members.alters_data = True

     def add_person(self, person):
-        from karaage.projects.models import Project
-        ct = self.content_type
-        if ct and ct.model_class() is Project:
-            raise DeprecationWarning(
-                'Add project group members via ProjectMembership.',
-            )
         self.members.add(person)
     add_person.alters_data = True

from karaage.

On second thoughts this code really is broken.

I thought I saw code that synced changes from Group to ProjectMembership, but in actual fact it syncs in the opposite direction, ProjectMembership to Group. There is a TODO in the code to fix this:

TODO: Automatic update project membership using signals from Group.members, using defaults defined below.

If fixing this, need to make sure you don't create a loop with ProjectMembership notifying changes to Group and Group notifying changes to ProjectMembership.

Reopening.

from karaage.

Hi Brian,

Sounds like the TODO is broken. The pattern should be that POSIX groups are output from other sources such as ProjectMembership, and as such sync should always be from to Group.

Regards,
Tyson.

from karaage.

You mean "sync should always be from ProjectMembership to Group" right?

from karaage.

Indeed - sync should always be from ProjectMembership to Group. Rewording fail...

from karaage.