Giter VIP home page Giter VIP logo

karaage's People

Contributors

andrewisaac avatar andrewspiers avatar brianmay avatar levlafayette avatar russell avatar sorrison avatar spearki avatar tysonclugg avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

karaage's Issues

tags inconsistant

Hello,

Previous Karaage tags used the format without a prefix:

  • 3.1.8
  • 3.1.9
  • 3.1.10

However now I see different prefixes being used:

  • 4.0a0
  • v4.0a1
  • karaage_4.0b1

Unless there is a good reason for changing, can we stick to the prefix-less format?

Having a consistent scheme makes it easier on tools like uscan to check if there was a new upstream release.

Thanks

grant_leader/revoke_leader broken

Environment:


Request Method: POST
Request URL: http://localhost:8080/projects/34/grant/brian/

Django Version: 1.7.4
Python Version: 2.7.8
Installed Applications:
['karaage.apps.Karaage',
 'karaage.plugins.kgapplications.plugin',
 'karaage.plugins.kgsoftware.plugin',
 'karaage.plugins.kgsoftware.applications.plugin',
 'karaage.plugins.kgusage.plugin',
 'djcelery',
 'django_xmlrpc',
 'captcha',
 'ajax_select',
 'jsonfield',
 'django_tables2',
 'tldap.methods',
 'tldap.django',
 'pipeline',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.humanize',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'mptt',
 'django_extensions']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.common.BrokenLinkEmailsMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'karaage.middleware.threadlocals.ThreadLocals',
 'karaage.middleware.saml.SamlUserMiddleware',
 'tldap.middleware.TransactionMiddleware',
 'audit_log.middleware.UserLoggingMiddleware')


Traceback:
File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py" in get_response
  111.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.7/dist-packages/django/db/transaction.py" in inner
  394.                 return func(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/django/contrib/auth/decorators.py" in _wrapped_view
  21.                 return view_func(request, *args, **kwargs)
File "/home/brian/tree/django/karaage/karaage4/karaage/projects/views.py" in grant_leader
  295.             project.leaders.add(person)

Exception Type: AttributeError at /projects/34/grant/brian/
Exception Value: 'QuerySet' object has no attribute 'add'

Needs to be updated to use ProjectMembership instead of project.leaders.

adding users to project group directly fails

Took me a while to reproduce this, adding users to the project is ok, but adding them to the group fails.

For some reason Karaage raises a DeprecationWarning, which makes it a fatal error, not a warning.

Environment:


Request Method: POST
Request URL: http://localhost:8080/groups/detail/edpnMe002/add/

Django Version: 1.7.4
Python Version: 2.7.8
Installed Applications:
['karaage.apps.Karaage',
 'karaage.plugins.kgapplications.plugin',
 'karaage.plugins.kgsoftware.plugin',
 'karaage.plugins.kgsoftware.applications.plugin',
 'karaage.plugins.kgusage.plugin',
 'djcelery',
 'django_xmlrpc',
 'captcha',
 'ajax_select',
 'jsonfield',
 'django_tables2',
 'tldap.methods',
 'tldap.django',
 'pipeline',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.humanize',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'mptt',
 'django_extensions']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.common.BrokenLinkEmailsMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'karaage.middleware.threadlocals.ThreadLocals',
 'karaage.middleware.saml.SamlUserMiddleware',
 'tldap.middleware.TransactionMiddleware',
 'audit_log.middleware.UserLoggingMiddleware')


Traceback:
File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py" in get_response
  111.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.7/dist-packages/django/db/transaction.py" in inner
  394.                 return func(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/django/contrib/auth/decorators.py" in _wrapped_view
  21.                 return view_func(request, *args, **kwargs)
File "/home/brian/tree/django/karaage/karaage4/karaage/people/views/groups.py" in add_group_member
  178.             form.save()
File "/home/brian/tree/django/karaage/karaage4/karaage/people/forms.py" in save
  257.         self.instance.add_person(person)
File "/home/brian/tree/django/karaage/karaage4/karaage/people/models.py" in add_person
  730.                 'Add project group members via ProjectMembership.',

Exception Type: DeprecationWarning at /groups/detail/edpnMe002/add/
Exception Value: Add project group members via ProjectMembership.

tests fail

If running ./run_tests.sh I get lots of failures in the tests.

Summary:

IntegrityError: Problem installing fixture '/home/brian/tree/django/karaage/karaage4/karaage/tests/karaage_data.json': Could not load karaage.Institute(pk=1): UNIQUE constraint failed: karaage_instituteauditlogentry.group_id

DoesNotExist: Allocation matching query does not exist.

DoesNotExist: Grant matching query does not exist.

OperationalError: no such table: software

DoesNotExist: Resource matching query does not exist.

DoesNotExist: ResourcePool matching query does not exist.

AssertionError: HTTP Error 404: /allocations/project-<project_id>/delete-allocation/<allocation_id>/ > /allocations/project-1/delete-allocation/1/

AssertionError: HTTP Error 404: /allocations/project-<project_id>/delete-grant/<grant_id>/ > /allocations/project-1/delete-grant/1/

AssertionError: HTTP Error 404: /resources/delete-resource/<resource_id>/ > /resources/delete-resource/1/

AssertionError: HTTP Error 404: /resources/delete-resource-pool/<resource_pool_id>/ > /resources/delete-resource-pool/1/

no way to disable plugins

Hello,

In Karaage 4, the plugins have been combined into the one git repository, containing one python distributable (one setup.py), which contains multiple packages (top level python modules).

Also in Karaage 4, the plugins are autoconfigured based on which ones are installed.

However, this has several difficulties.

  • All plugins get configured, there is no way to disable given plugins if installed.
  • It is not possible to install only a subset of the modules, because they all belong to the one distributable. This is important, as some of the plugins have complicated dependencies.

While both problems affect Debian installs, they affect installs from pypi too.

This is why I had the plugins split up into separate source/separate distributable.

Unfortunately I can't think of a better solution. Anything I can think of is going to become more complicated then just splitting them up again I think.

Thanks

Migrations broken

As per private email; this is with mysql in Debian wheezy:

root@debian-7:/home/vagrant# kg-manage migrate
Operations to perform:
  Synchronize unmigrated apps: pipeline, mptt, djcelery, captcha, django_tables2, ajax_select, jsonfield
  Apply all migrations: karaage, methods, sessions, sites, contenttypes, kgsoftware, kgusage, kgapplications
Synchronizing apps without migrations:
  Creating tables...
  Installing custom SQL...
  Installing indexes...
Running migrations:
  Applying karaage.0003_unique_groups... OK
  Applying karaage.0004_auto_karage4...Traceback (most recent call last):
  File "/usr/local/bin/kg-manage", line 7, in <module>
    execfile(__file__)
  File "/home/vagrant/src/karaage4/sbin/kg-manage", line 7, in <module>
    management.execute_from_command_line()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 377, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/usr/lib/python2.7/dist-packages/django/core/management/commands/migrate.py", line 160, in handle
    executor.migrate(targets, plan, fake=options.get("fake", False))
  File "/usr/lib/python2.7/dist-packages/django/db/migrations/executor.py", line 63, in migrate
    self.apply_migration(migration, fake=fake)
  File "/usr/lib/python2.7/dist-packages/django/db/migrations/executor.py", line 97, in apply_migration
    migration.apply(project_state, schema_editor)
  File "/usr/lib/python2.7/dist-packages/django/db/migrations/migration.py", line 107, in apply
    operation.database_forwards(self.app_label, schema_editor, project_state, new_state)
  File "/usr/lib/python2.7/dist-packages/django/db/migrations/operations/special.py", line 69, in database_forwards
    schema_editor.execute(statement, params=None)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/schema.py", line 99, in execute
    cursor.execute(sql, params)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/utils.py", line 81, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/utils.py", line 63, in execute
    return self.cursor.execute(sql)
  File "/usr/lib/python2.7/dist-packages/mysql/connector/django/base.py", line 133, in execute
    return self._execute_wrapper(self.cursor.execute, query, args)
  File "/usr/lib/python2.7/dist-packages/mysql/connector/django/base.py", line 125, in _execute_wrapper
    utils.DatabaseError(err.msg), sys.exc_info()[2])
  File "/usr/lib/python2.7/dist-packages/mysql/connector/django/base.py", line 113, in _execute_wrapper
    return method(query, args)
  File "/usr/lib/python2.7/dist-packages/mysql/connector/cursor.py", line 494, in execute
    self._handle_result(self._connection.cmd_query(stmt))
  File "/usr/lib/python2.7/dist-packages/mysql/connector/connection.py", line 683, in cmd_query
    statement))
  File "/usr/lib/python2.7/dist-packages/mysql/connector/connection.py", line 601, in _handle_result
    raise errors.get_exception(packet)
django.db.utils.DatabaseError: Incorrect integer value: 'f' for column 'is_project_supervisor' at row 1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.