Giter VIP home page Giter VIP logo

smells's Introduction

smells

Things you shouldn't do in code.

These are all real-life, production code examples I've found.

Testing

// dev level: senior.  Seriously, though?  WHY EVEN FEKKIN BOTHER?!?!?!?
package com.package;
import org.junit.Test;

public class CSVUtilitiesTest {


    @Test
    public void test() {

    }

}

Cyber Boolean

crimes against boolean zen

// dev level: 3
return null == entity ? null : entity;
// dev level: 3 (ish?)
return boolCondition ? true : false;
// honestly, what is it with ternaries? why.
// dev level: architect
  if (entity != null) {
    return entity;
  } else {
    return null;
  }
/*
  dev level: senior
  
  this one gets bonus points.  Can you tell why?
*/
System.setProperty("flyway.url", databaseUrl);

if (databaseUrl == null || someCondition || databaseUrl == null) {...}
/* 
   dev level: senior. me. 
   but there's no other way to write it; I was forced to use this API.
   and no.  This isn't java.lang.Boolean.
*/
...(Boolean.builder().withValue(false).build())...

smells's People

Contributors

meldaravaniel avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.