meltir / imdb-review-scraper Goto Github PK

add phpunit tests

1 Below warning is show on pipeline, where the date key for the composer cache is stored.

Warning: The `set-output` command is deprecated and will be disabled soon.   
Please upgrade to using Environment Files. 
For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

above link

2 Update the key to also use an md5 or eq (sha256?) of composer.json - to update the cache when changes are made to libs and versions on the same day

3 Add caching of phpunit coverage into infection pipeline so its not run twice

4 Dont run the build pipeline on anything other than a PR (i think it also runs on a merge for no reason, eating up my free minutes - check this)

What if someone wants a couple of diff users ?
You have to create many instances ?
Silly. Might as well take the user when getting all movies or somewhere else.

This smells bad.

Implement a generator, cachable and iterator interface - to not have to rely on the getall always.
See what else can be done (lazy loading, fibers?).

Shoehorn as much in as I can :P

Implement some sort of token to be able to resume a scrape after one is interrupted (times out etc).

If dependabot changes pass the tests, automerge it.

All of the shiny badges, build, tests, infection, security whatever else.
Lets make a collection of things I could do, and tick them off.

Going to depend on the build pipeline working (#3)

Switch to a generic PSR client interface, rather then relying on this concrete implementation.
I don't care what the http client is, as long as it works.

Dig into if this is doable and how - lookup other libs that dont care who provides http, like symfony and laravel.
Maybe only require guzzle in dev as a concrete implementation to test against ?

Implement semver in the pipelines after (or maybe prior ?) a merge into master - tag a github release automatically.
Confirm composer.json has all the fields required for a lib, author, etc.

Add phpinsights checks to composer.
Go over findings and figure out what the passing grades should be for the pipeline.
Implement checks on the pipeline.

Will rector allow me to generate a 7.4 compatible version, that perhaps fails some strict stan checks and others - but works fine without it ?
Is rector free ? I haven't tried it yet - just read about it.
What are the alternatives ?

Find a generic DTO object that is framework agnostic.

Add docker run commands to readme/docker docs about how to download lib, build and test it using only docker run commands.
Add composer setup/commands to that as well if running on a full system.

use Meltir\ImdbRatingsScraper\ImdbRatingsScraper;

This is redundant redundant.

there has to be a better way. kiss, but come on...
check how others do it.

Follow https://github.com/doctrine/DoctrineBundle/blob/2.11.x/.github/workflows/continuous-integration.yml and try to replicate - specific lts versions in test matrix, stable/dev revisions of core required libs, matrix with those versions of libs.
Merge all these into one or a few workflows ? I don't like how bitty they have become.
Share phpunit coverage cache with infection, see if I can share other caches.
Run automated workflows on a schedule to check if there are dependabot prs and merge if there are no errors (there should be another ticket for this).

Setup a remote azure pipelines (alpine based ?) build agent and use it to run build/tests via github pr&merge.
Deploy pipeline should also tag a release etc. Full monty and all that.