meorawr / libdbcompartment Goto Github PK

Hey @Meorawr, thanks so much for creating this library.

My question to you is, now that LibDBIcon has added support for the addon compartment natively, is there a strong reason to use LibDBCompartment over LibDBIcon? This isn't meant to be a 'gotcha' type question, I'm genuinely curious if I should migrate to yours over using LibDBIcon's compartment feature, and whether or not you plan on supporting this library in the long-term or if you plan to merge your version into LibDBIcon itself.

Thanks!

Hi there, thank you for your helpful library.

The minimap icon data object I use works fine with LibDBIcon but that same data object used with LibDBCompartment produces the following error trying to display a dropdown menu on right-click:

3x SharedXML/UIDropDownMenu.lua:1133: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: DropDownList1:SetPoint.
[string "=[C]"]: in function `SetPoint'
[string "@SharedXML/UIDropDownMenu.lua"]:1133: in function `ToggleDropDownMenu'
[string "@VuhDo/VuhDoAddonAdapter.lua"]:92: in function `OnClick'
[string "@VuhDo/Libs/LibDBCompartment/LibDBCompartment-1.0-3.lua"]:198: in function `OnDropDownButtonClick'
[string "@VuhDo/Libs/LibDBCompartment/LibDBCompartment-1.0-3.lua"]:67: in function `func'
[string "@SharedXML/UIDropDownMenu.lua"]:1007: in function `UIDropDownMenuButton_OnClick'
[string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1: in function <[string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1>

Locals:
(*temporary) = DropDownList1 {
 0 = <userdata>
 dropdown = Frame {
 }
 shouldRefresh = false
 numButtons = 1
 Border = DropDownList1Backdrop {
 }
 maxWidth = 50.833355
}
(*temporary) = "TOPLEFT"
(*temporary) = "DropDownList1Button1"
(*temporary) = "BOTTOMLEFT"
(*temporary) = 0
(*temporary) = -5

The data object specifics can be seen here: https://gitlab.vuhdo.io/vuhdo/vuhdo/-/blob/master/VuhDoAddonAdapter.lua#L87

Any thoughts on what could be the issue?

Thanks again!

Hi @Meorawr,

I honestly have no idea how I ended up looking at the GitHub workflows in this repo, but somehow I did and I thought I would just point out a couple quick things. Also, please feel free to ignore me entirely lol.

In pull_request.yml and release.yml you are using actions/checkout@v2 still, and I think they're trying to get everyone to move over to actions/checkout@v3 before they fully deprecate it. Switching to v3 for me was totally plug-and-play, so that should be pretty easy.

Also, in pull_request.yml and release.yml you are using actions/setup-ruby@v1 which from my understanding is deprecated in favor of ruby/setup-ruby@v1 which is maintained by upstream Ruby themselves. (Also, I don't think your release.yml 'needs' the ruby dependency, but you probably know something I don't).

Updating these might shave 1s off your runners, so prioritize this however you will ;-)