merchantpug / bovines-and-buttercups Goto Github PK

License: MIT License

Java 100.00%

bovines-and-buttercups's Introduction

Hi what's up.

I'm MerchantPug, I'm a girl from Australia who works on Minecraft mods and has a heavy interest in game design. I'm also the owner and project lead of the Greenhouse Modding group.

I've made Minecraft mods such as Bovines and Buttercups, TooManyOrigins and Apugli and I don't plan on stopping anytime soon.
I enjoy making things data driven.
I have an interest in TTRPGs that aren't D&D and games, usually platformers and RPGs.
My pronouns are she/they.

You can view my mods on Modrinth here.

The best place to reach me is through Discord, as I'm quite active there.

Socials

bovines-and-buttercups's People

Contributors

Stargazers

Watchers

Forkers

lobster0228 nezila

bovines-and-buttercups's Issues

Improve breeding condition systems

Currently, it's kinda limited and clunky to work with.

I'll be looking into refining the system in the next minor version.

Move testassets and testdata directories into Common.test

The 1.19.3 version does not have items in any creative tab.

I forgot to do this aaa.

[Major Crash] Bonemeal Buttercup

Fabric 1.20.1
Version: https://modrinth.com/mod/bovines-and-buttercups/version/1.6.1+1.20-fabric

Using bonemeal causes locking crash, completely unable to load back in that area without players crashing. Believe it's connected to the flowers placed on the ground as removing the cows still resulted in crashing.

java.lang.IllegalArgumentException: Cannot get property class_2758{name=flower_amount, clazz=class java.lang.Integer, values=[1, 2, 3, 4]} as it does not exist in Block{bovinesandbuttercups:buttercup}
	at net.minecraft.class_2688.method_11654(class_2688.java:98)
	at net.minecraft.class_2356.method_9530(class_2356.java:562)
	at net.minecraft.class_4970$class_4971.method_26172(class_4970.java:1032)
	at net.minecraft.class_3959$class_3960.get(class_3959.java:67)
	at net.minecraft.class_3959.method_17748(class_3959.java:40)
	at net.minecraft.class_1922.method_17743(class_1922.java:80)
	at net.minecraft.class_1922.method_17744(class_1922.java:193)
	at net.minecraft.class_1922.method_17742(class_1922.java:73)
	at net.minecraft.class_1297.method_5745(class_1297.java:1715)
	at net.minecraft.class_757.method_3190(class_757.java:652)
	at net.minecraft.class_757.method_3188(class_757.java:1067)
	at net.minecraft.class_757.method_3192(class_757.java:880)
	at net.minecraft.class_310.method_1523(class_310.java:1219)
	at net.minecraft.class_310.method_1514(class_310.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Head --
Thread: Render thread
Stacktrace:
	at net.minecraft.class_2688.method_11654(class_2688.java:98)
	at net.minecraft.class_2356.method_9530(class_2356.java:562)
	at net.minecraft.class_4970$class_4971.method_26172(class_4970.java:1032)
	at net.minecraft.class_3959$class_3960.get(class_3959.java:67)
	at net.minecraft.class_3959.method_17748(class_3959.java:40)
	at net.minecraft.class_1922.method_17743(class_1922.java:80)
	at net.minecraft.class_1922.method_17744(class_1922.java:193)
	at net.minecraft.class_1922.method_17742(class_1922.java:73)
	at net.minecraft.class_1297.method_5745(class_1297.java:1715)
	at net.minecraft.class_757.method_3190(class_757.java:652)
	at net.minecraft.class_757.method_3188(class_757.java:1067)

-- Affected level --
Details:
	All players: 1 total; [class_746['A5ho9999'/377426, l='ClientLevel', x=-356.89, y=76.03, z=2630.40]]
	Chunk stats: 4096, 52
	Level dimension: minecraft:overworld
	Level spawn location: World: (-92,110,120), Section: (at 4,14,8 in -6,6,7; chunk contains blocks -96,-64,112 to -81,319,127), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,-64,0 to -1,319,511)
	Level time: 21152295 game time, 19610399 day time
	Server brand: fabric
	Server type: Non-integrated multiplayer server
Stacktrace:
	at net.minecraft.class_638.method_8538(class_638.java:458)
	at net.minecraft.class_310.method_1587(class_310.java:2406)
	at net.minecraft.class_310.method_1514(class_310.java:826)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Locked In advancement Icon has a white nectar bowl

The bowl of nectar doesn't have a source.

Merge Fabriclike module into Fabric and Quilt

Because the Fabriclike module is not applying the files to Fabric/Quilt or vice versa during building, I will have to change how my files are managed.

duplicate input class net/merchantpug/bovinesandbuttercups/util/StatePropertiesUtil, from ...\bovines-and-buttercups\Fabric\build\devlibs\Bovines-And-Buttercups-Fabric-1.0.0+1.19.3-dev.jar and ...\bovines-and-buttercups\Fabriclike\build\devlibs\Bovines-And-Buttercups-Fabriclike-1.0.0+1.19.3-dev.jar

(The above applies to all files in the Fabriclike module)

Finish documentation

Finish up datapack and addon/integration documentation.

Fatal Error

latest.log

Here is my log, I've been mo(o)ving to 1.20.2 today and downloaded this file to replace the moobloom mod I had in 1.16.5. I can't make heads or tails of log files, but ATLauncher helpfully marked this mod as causing a fatal error. Hope this helps, and tell me if I should send a more verbose log, as I have my settings to only show the dumbed down info.

Mod Breaks with Forge Update

Anything past Forge Version 45.0.22, The Mod fails to load .

[FORGE] Reload command fails with mod installed

B&B version 1.2.0 (but I've encountered this bug in previous versions as well. Unsure when it started)
MC version 1.19.2
Forge version 43.2.0

Tested in a new instance with only this mod installed. Using the /reload command to reload datapacks results in this error.

[18Feb2023 12:09:00.687] [Server thread/WARN] [net.minecraft.server.commands.ReloadCommand/]: Failed to execute reload
java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot read field "f_8906_" because the return value of "java.util.function.Supplier.get()" is null

the stacktrace eventually shows this line

at net.merchantpug.bovinesandbuttercups.BovinesAndButtercupsForge.lambda$addForgeBusEventListeners$9(BovinesAndButtercupsForge.java:149) ~[Bovines-And-Buttercups-Forge-1.2.0+1.19.2.jar%23146!/:1.2.0+1.19.2]

I'll also attach the full log for you to take a look at! I'm trying to add this mod to a custom modpack of mine with a LOT of custom recipes, so being able to successfully /reload is super important! Otherwise fantastic mod! Thanks, and hopefully this is an easy fix!

latest.log

1.19.2 Crash on world load

Minecraft 1.19.2
Forge 43.2.4
BAB 1.1.1

Testing an update for my public mod pack and server. loading into a brand new world gives this crash. appears to be due to one of the classes that spawns the mobs.

https://gist.github.com/Zelioth/fa380344ef81cc7f676786943918c706

[1.20.1] Crash "Rendering entity in world"

Hi, I was doing some testing and when I teleported back to my main testing base, I got this crash: https://gist.github.com/katubug/4aa819f097bbecb025afb5018277aba9

I had had several Mooblooms (yellow and pink) around for a while, but it was only when I teleported away and came back that I got the crash. Unfortunately I don't have the matching latest.log at hand because this was a day or two ago, but if you need it I can try to hunt through them.

This is on B&B 1.9.0, Forge 47.2.19.

Rendered model transforms for custom flower/mushroom item models do not apply

Model transforms for custom items get the base model's transforms as opposed to the model that's actually being rendered's transforms.

I'm unsure how to fix this myself and I'd love for somebody else that knows how to PR a fix.

[1.19.2-Forge] Bovine And Buttercups mod will not run with Colorful Azalea mod

I was testing some mod compat work but then found that Colorful Azalea and Bovine and Buttercups mod will not run together. Each one can run separately. Using latest Forge and latest version of each mod for 1.19.2.
https://www.curseforge.com/minecraft/mc-mods/colorfulazaleas
https://www.curseforge.com/minecraft/mc-mods/bovines-and-buttercups

The issue is I am not sure what this error means or how Colorful Azalea is even involved. The latest.log file had no info but the launcher.log did.
Game/game () Info Exception in thread "main" java.lang.module.ResolutionException: Modules colorfulazaleas and bovinesandbuttercups export package net.merchantpug.bovinesandbuttercups to module minecraft
https://paste.ee/p/eN8ok

Duplicated item models when using BnB with Geckolib

Minecraft 1.20.1
Fabric loader 0.14.21
Fabric API 0.86.1
Bovines and Buttercups 1.9.0 (latest)
Geckolib 4.2.1 (latest)

Some items, most notably bowls of nectar, have a copy of the item model near them in inventory, in item frames, as dropped items, etc. The copy seems to be shifted by a few pixels to the upper left corner and a bit backwards (it appears to be behind the item frame).
This occurs only when Geckolib is installed. Without it, the items render correctly.
Affected items include: all bowls of nectar and custom flower, custom mushroom, custom mushroom block in the item form (not placed).

A zombie holding the item:

Items in item frames:

Items in invisible item frames:

Items laying on the ground with hitboxes shown:

Other items:

Lockdown Status Effect doesn't render properly with InventoryHUD+

Tested on Fabric, should apply to Quilt too

How to Solve

Turn off Potion Overlay. (You can still use the inventory overlay)

Why I will not be fixing it

The mod is ARR and Closed Source, meaning I'd be treading in dangerous copyright territory if I were to attempt to implement a fix.

Startup crash from EMI 1.0.1

Hi hello! the funky EMI integration for status effects has broken and needs suring up on EMI 1.0.1, where it causes a startup crash

https://mclo.gs/MI7bm32

emilyploszaj/emi#198 (comment)

Crash with JEI

[11:55:39] [Render thread/ERROR] (Minecraft) Unhandled game exception
org.quiltmc.loader.impl.entrypoint.QuiltEntrypointException: Exception while loading entries for entrypoint 'jei_mod_plugin' provided by 'bovinesandbuttercups'
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage.lambda$getEntrypointContainers$1(EntrypointStorage.java:225) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:54) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:34) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
	at mezz.jei.fabric.startup.FabricPluginFinder.getInstances(FabricPluginFinder.java:25) ~[transformed-mod-jei.i0:0/:?]
	at mezz.jei.fabric.startup.FabricPluginFinder.getModPlugins(FabricPluginFinder.java:16) ~[transformed-mod-jei.i0:0/:?]
	at mezz.jei.fabric.startup.ClientLifecycleHandler.<init>(ClientLifecycleHandler.java:40) ~[transformed-mod-jei.i0:0/:?]
	at mezz.jei.fabric.JustEnoughItemsClient.lambda$onInitializeClient$0(JustEnoughItemsClient.java:28) ~[transformed-mod-jei.i0:0/:?]
	at org.quiltmc.qsl.lifecycle.api.client.event.ClientLifecycleEvents.lambda$static$0(ClientLifecycleEvents.java:45) ~[transformed-mod-quilt-lifecycle-events.i0:0/:?]
	at net.minecraft.class_310.handler$dlf000$quilt_lifecycle_events$clientReady(class_310.java:19476) ~[transformed-mod-minecraft-v1.19.2.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:747) ~[transformed-mod-minecraft-v1.19.2.jar:?]
	at net.minecraft.client.main.Main.method_44604(Main.java:244) [transformed-mod-minecraft-v1.19.2.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:51) [transformed-mod-minecraft-v1.19.2.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:524) [quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82) [quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28) [quilt-loader-0.19.2-beta.2.jar:?]
Caused by: org.quiltmc.loader.api.LanguageAdapterException: java.lang.ClassNotFoundException: net.merchantpug.bovinesandbuttercups.client.integration.jei.BovinesJeiPlugin
	at org.quiltmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:52) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:115) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage.lambda$getEntrypointContainers$1(EntrypointStorage.java:223) ~[quilt-loader-0.19.2-beta.2.jar:?]
	... 25 more
Caused by: java.lang.ClassNotFoundException: net.merchantpug.bovinesandbuttercups.client.integration.jei.BovinesJeiPlugin
	at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]
	at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[?:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at org.quiltmc.loader.impl.launch.knot.KnotClassDelegate.loadClassOnly(KnotClassDelegate.java:178) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:150) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:228) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at java.lang.Class.forName0(Native Method) ~[?:?]
	at java.lang.Class.forName(Class.java:467) ~[?:?]
	at org.quiltmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:115) ~[quilt-loader-0.19.2-beta.2.jar:?]
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage.lambda$getEntrypointContainers$1(EntrypointStorage.java:223) ~[quilt-loader-0.19.2-beta.2.jar:?]
	... 25 more

[Forge 1.19.2] Bovine&Buttercup's JEI stuff breaks Bumblezone JEI recipes

Log entries: https://controlc.com/01e14e27

I can export my testing modpack that is full of tons of mods. I saw this in the log where my Bumblezone mod tries to register a Bee Queen trade to JEI that takes flowers to show rewards possible for them. Bovine&Buttercups crashes the flower trade registrations due to a null fuield


java.lang.NullPointerException: Cannot invoke "net.merchantpug.bovinesandbuttercups.data.block.FlowerType.equals(Object)" because "flowerType" is null
	at net.merchantpug.bovinesandbuttercups.integration.jei.subtype.CustomFlowerSubtypeInterpreter.apply(CustomFlowerSubtypeInterpreter.java:22) ~[Bovines-And-Buttercups-Forge-1.5.0+1.19.2.jar%23342!/:1.5.0+1.19.2-forge]
	at net.merchantpug.bovinesandbuttercups.integration.jei.subtype.CustomFlowerSubtypeInterpreter.apply(CustomFlowerSubtypeInterpreter.java:11) ~[Bovines-And-Buttercups-Forge-1.5.0+1.19.2.jar%23342!/:1.5.0+1.19.2-forge]
	at mezz.jei.library.ingredients.subtypes.SubtypeManager.lambda$getSubtypeInfo$0(SubtypeManager.java:23) ~[jei-1.19.2-forge-11.6.0.1015.jar%23415!/:11.6.0.1015]