merrit / flutter_flatpak Goto Github PK

System: Fedora 36
Desktop Environment: GNOME 42
Flatpak version: 1.12.7

I found this in the current release of Feeling Finder Merrit/feeling_finder@c45b99f. When I select the system theme it always shows the dark theme no matter if the system theme is light or dark.

I decided to check what this command produces in different modes, I just typed this in the terminal:

dbus-send --print-reply --dest=org.freedesktop.portal.Desktop /org/freedesktop/portal/desktop org.freedesktop.portal.Settings.Read string:'org.freedesktop.appearance' string:'color-scheme'

In the light mode: variant variant uint32 0
In the dark mode: variant variant uint32 1

Your plugin code checks that if it's command returns 2 it's a light theme, but on my system it returns 1 which tells the plugin it's a dark theme when it isn't.

When I change the theme on the system, for example in GNOME 42 (Fedora 36), the theme changes in real time and there is no way in the plugin to listen for these changes so that the app can react to the theme change. It's probably necessary to setup a D-Bus listener. We can use dbus package for this purpose.