metmuseum / marble Goto Github PK

View Code? Open in Web Editor NEW

19.0 11.0 5.0 228.8 MB

Marble is the design system of The Metropolitan Museum of Art 🏛

Home Page: https://marble.metmuseum.org

JavaScript 62.64% SCSS 37.26% Dockerfile 0.09%

design-system component-library component-driven design-systems storybook styleguide

marble's People

Contributors

Stargazers

Watchers

Forkers

jackoliver markshells user01010011 xlcb danielhaim1

marble's Issues

Migrate Knobs to Controls via Args?

Knobs is now deprecated, but it might continue to get some community support. Otherwise, we should migrate to @storybook/addon-controls via Story Args. See storybookjs/storybook#15525

might be cool to use something like jsdelivr to make Marble’s /dist available via github releases for users that aren’t on npm

https://www.jsdelivr.com

Node-gyp fails on CircleCI container node@latest

node-gyp (typical!) throws a vague error (typical!) on the circleci/node@latest so I am temporarily locking the container to the last passing image: circleci/node@sha256:64300d4fa16456a547e9e747a10e5eb02419a477ac08a592244dc5ca8adbda72

Creating this issue to remember to unlock this image once node@latest can be used again.

Reduce h3 font size on mobile to 24px

The scaling algorithm for h3 should be adjusted so that on a mobile (375px width) screen the pixel size is 24px. This will ensure better type hierarchy with the other headings/body text on mobile. See attached for sizing guidelines for all headings.