mfeingol / htmltextwriter Goto Github PK

The method name AddStyleAttrbiute(string, string) appears to be a typo. Here is a patch to fix it.

diff --git a/Source/HtmlTextWriter/HtmlTextWriter.cs b/Source/HtmlTextWriter/HtmlTextWriter.cs
index ebad04b..a1449a9 100644
--- a/Source/HtmlTextWriter/HtmlTextWriter.cs
+++ b/Source/HtmlTextWriter/HtmlTextWriter.cs
@@ -107,7 +107,9 @@ namespace System.Web.UI
         public void AddStyleAttribute(HtmlTextWriterStyle key, string value) => this.AddStyleAttribute(key, value, true);
         public void AddStyleAttribute(HtmlTextWriterStyle key, string value, bool encode) => AddStyleAttribute(key.ToName(), value, encode);

-        public void AddStyleAttrbiute(string name, string value) => this.AddStyleAttribute(name, value, true);
+        [Obsolete("Typo in method name preserved for binary compatibility. Use the corrected method AddStyleAttribute(string, string).")]
+        public void AddStyleAttrbiute(string name, string value) => this.AddStyleAttribute(name, value);
+        public void AddStyleAttribute(string name, string value) => this.AddStyleAttribute(name, value, true);
         public void AddStyleAttribute(string name, string value, bool encode)
         {
             if (encode)

In the Dispose function this.InnerWriter.Dispose(); is called.
In the original version https://referencesource.microsoft.com/#System.Web/UI/HTMLTextWriter.cs dispose was not overwritten and the inner writer is left open. This can lead to exceptions when porting code.

Having said that, changing back to the original behaviour could break code that is already using this lib.

In general the class should not dispose things that it did not create.

In using HtmlTextWriter to write directly to the response stream in asp.net core, those writes need to be async.

HtmlTextWriter does support some async methods to do writes, but it lacks async alternatives for methods like WriteFullBeginTag, WriteEndTag, WriteBeginTag and similar methods.

For <TextArea> tags, the value of the TextArea is in between the Tags, ex, <TextArea> In a Text area </TextArea>.

The issue is that calling HtmlTextWriter.Write() will always add tabs / new lines after the closing tab, meaning the text area will include those newlines / tabs in the value on the page.

It seems like the .NET HtmlTextWriter only adds tabs when / after calling WriteNewLine(), but, if Write() is only ever called, then no tabs / no newlines would be added.

Recreation steps: Render a <TextArea> tag. Either look at the InnerWriter's value or use jQuery.val() on the rendered element to see that it has tabs / new lines in it.

Requested Functionality: There should be a way to write a value without having tabs/ newlines inserted after a closing tag, >.

Hi Max,

.net core is missing AddStyleAttribute. Can you please add AddStyleAttribute in HTMLTextWriter?