mganeko / browser_mcu_core Goto Github PK

I'm fascinated by this project. You're a superhero to me.

I'm running the demo in conference mode for fun and science, and it really works fantastic with video, just failing to work out the AUDIO_MODE_MINUS_ONE handling. The theory is clear, and we're passing peerIds different from stream.id, but I can't get mixed audio back to the clients from mcu.getMixStream();

Could you perhaps clarify a detail from the prepareMinusOneStream example:

let id1 = 'member1';
let mixStream1 = mcu.prepareMinusOneStream(id1);
mcu.addRemoteVideo(remoteStream1);
mcu.addRemoteAudioMinusOne(id1, remoteStream1);

let id2 = 'member2';
let mixStream2 = mcu.prepareMinusOneStream(id2);
mcu.addRemoteVideo(remoteStream2);
mcu.addRemoteAudioMinusOne(id2, remoteStream2);

I understand from here on, we're always using the ID to refer to mixed streams, but are the mixStream1 and mixStream2 variables used or needed anywhere afterwards?

Thanks for sharing this entertaining code!

Why 36 ?
Is that an aribtrary limit you put ?

Would be great if you can publish a ready to test/benchmark product like a MCU or SFU server.
Looks very promising for now