mgeraci / cocktails Goto Github PK

Mug glass makes no sense, so this should become a database field.

Also: mug needs an illustration.

One example is the Harvest Moon, though there are others. Clicking the link to get the unauthenticated recipe results in a 404 error.

Recipes that are private should have a way of generating a unique-but-hard-to-guess url for sharing that doesn't require authentication.

Recipes with a string listed twice in the ingredient list (e.g., Basil Leaves and Sprig of Basil) show up in search once for each instance of the string's use. Recipes should be deduplicated before returning the list in search.

I was looking for The Charles in the C section, and couldn't find it, so I should ignore articles.

This stackoverflow answer has a pretty good explanation of a strategy: https://stackoverflow.com/questions/12544310/how-to-custom-sort-a-django-queryset

If you search for an ingredient like "aquavit", you get a nice list of recipes that have any ingredient that has that string in it. But if you go to the ingredients page and click on the ingredient "aquavit", you don't get most of the recipes, because most of them have specific types of aquavit — therefore the ingredient does not match.

One solution could be to change the way the ingredient page works to be more like search, and maybe that's a really easy solution. Another idea could be to add some sort of inheritance to ingredients, so specific types of liquor could inherit from a base class of that ingredient type. 

Searching for frose does not bring up the recipe for frosé. There are a handful of other examples, as well, like benedictine.

Certain categories would be:

• recipes
• ingredients
• large format

Other possibilities within recipes could include:

• aperitifs
• long drinks
• cordials and fancy mixers

But instead, on the browse sources page, they display in order of creation.

The app is smart enough to display recipes that have the same name with the source appended (e.g., Mai Tai (Smugger's Cove) and Mai Tai (Speakeasy)). However, when entering a recipe, the url slug for it is automatically generated from the recipe name, and nothing there knows about previously existing recipes with the same name. This can yield a conflict; the recipe is added successfully, but going to the url throws a 500 as django doesn't know which recipe to return.

The safest solution would seem to be a recipe-save-time check for the uniqueness of the slug. It could even programatically add the source as a suffix if there's a conflict! Or just add -2 or something.

Separately, it may be worth not having the app 500 in this case, but if the save-time solution is solid that may not be necessary.

For recipes that make a batch of drinks, it would be nice to have an optional field that tells the user how many drinks (or what volume) the recipe makes.

Case in point:

it seems like clicking an ingredient, like "orange", when not authenticated is leaking authenticated recipes. you still can't read the recipes, but this gives you the list.

The spacing's all messed up.

If you search for gin, the recipe Bufala Negra is returned, which contains the ingredient ginger ale. It may be better to just return full word matches.

This would mean that it could pluralize properly.