mgesbert / vscode-indent-nested-dictionary Goto Github PK

If a nested dictionary has comments in it, whether on their own lines, or at the end of lines with code on them, the formatter does not take this into account and reflows with the comments. This causes lines to become commented out and that breaks the dictionaries.

For example:

{
   "foo": [
       # this is a comment
      1, 2, 3
  ],
  # this is another comment
  "baz": {
     "a": "b",
    "c": "d",
 }
}

Becomes

{
    "foo": [
        #thisisacomment1,
        2,
        3
    ],
    #thisisanothercomment"baz": {
        "a": "b",
        "c": "d",
    }
}

Note that the first element of the foo array gets slurped up into the comment and the second element of the outer dictionary (baz) is commented out leaving a broken nested dictionary.

Currently using tabs for indentation is hard-coded. Would be nice to have the code honor the current editor indentation setting for indentation and use tabs or the configured number of spaces.

Awesome and incredibly useful extension!!

Hi

Thank you for your tool. Really helpful. I use it to format several test fixtures. Your tool makes it easier to get an overview of complex data structures. However, I think that the readability would improve if no newlines were added for empty lists and objects(dicts). Example with this {"foo":[{}]}:

Now:

{
	"foo": [
		{
		}
	]
}

Future:

{
	"foo": [{}]
}