mgovea / openrct2-ride-price-manager Goto Github PK

Maybe do this, maybe don't. Came up in #113.

As mentioned in this issue in the Open RCT 2 Project, the Plugin API doesn't prevent the Plugin from setting prices on rides, even when the ride is a Pay for Entry / Free Rides scenario.
I played a round of Amity Airfield, and even though my entrance price was very reasonable (30€ for a park with 3 Coasters and 5 Flatrides) I constantly got messages that my park entrance fee was way too high, no guests were spawning without advertising and I got the worst value park award two times in a row.
I would really enjoy it if the plugin would disable itself in these scenarios or if it got a checkbox that disabled the plugin and set all prices to Free to "reset" the modified prices in these scenarios (which the user can't reset using the GUI)

Admins are players with the kick_player permission.

Obviously, #116 should not apply to these players.

This idea came up in #113.

Describe the bug
I installed the plugin and started testing it in an existing map. It worked fine and I decided to start a new map. I replaced the savefile and now the plugin no longer does anything. During my testing, I did get the feeling that the "Lazy tax" option did not work. Setting it to a different value, did not change the ticketprice. I also noticed that when I clicked on the manual refresh, then the price would be a lot lower, before changing again to a much higher numer at the start of the new day.

The dedicated OpenRCT2 server runs as a Docker container on Unraid.

To Reproduce
Steps to reproduce the behavior:

1. Run a dedicated server
2. Install the plugin
3. Reboot the server
4. Check that the plugin works. I checked it by clicking the button to make all rides free.
5. Shutdown server
6. Replace savefile with the world that you want to play
7. Reboot the server
8. Open the map that you just replaced
9. The plugin no longer does anything

Expected behavior
I exepected the plugin to work on any savefile that I load in the server.

Screenshots
I can make screenshots if needed, but am not sure if a screenshot of the plugin helps here, since the buttons do not work.

Desktop (please complete the following information):

• OS: Unraid 6.9.2
• Docker container https://hub.docker.com/r/ich777/openrct2server/
• OpenRCT version 0.4.0

Additional context
I am not great at debugging things, so please tell me what you need and where I can find it.

Investigate & maybe fix.

Mentioned by @kscheel in #37 (comment)_

Hi Mark,
maybe you remember me, I implemented the "Ignore Free Rides" feature.

Recently, the plug-in API has been enhanced; now, it is possible to query the climate data. Furthermore, since the last release in April, there were a lot of other features added that bring more possibilities.

A few days ago, I cloned your repo and started working on price management for shops, toilets, ride photos and the park entry fee. As the plug-in grew more complex, I refactored the config and window code to what I personally think makes it easier to use.

Soon, there was no sense in submitting a PR anymore, as there was not much left of the original code. Thus, I set up a new repo with my own project template. I made everything ready for release and pushed it here: OpenRCT2 Price Manager.

Now, I could easily just publish the plug-in and submit it to the plug-in repo, but I wanted to discuss it with you first.
I really do not want to have any bad blood between us and I do not want you to get angry or upset because I "stole your plug-in" or something.

For me, the thing is that I already spent a lot of time on the plug-in, polishing thing off to be ready for release. So, I want to get this published soon. From a copyright perspective, I do not see any problems:

• Right now, the code is completely refactored, apart from very few lines there is probably nothing left from the original code.
• I already had the idea for this plug-in before I learned that it already existed. Most features are new anyway.

On the other hand, your plug-in already has a large user base and it might be better to not have to plug-ins that do very similar things. Especially, I do not want to "steal" your users, but I think that this new version would make the old one obsolete for everyone that is interested in managing shop prices etc. (unless you decide to implement the features yourself).

I would like to hear your opinion on this issue. I have no problem just publishing this as a new, separate plug-in, but if you want, we can try and find some compromise.

Best,
Stephan

I just got this plugin and all I need to say is, this plugin is making my OpenRCT2 gameplay better. However, I do use transport rides quite often and I always make them free entry so that guests will ride them no matter what. This plugin, if activated, automatically sets prices on all transport rides, and I have to disable the plugin and manually set all the transport rides to free. I'd like to request a change to this plugin such that even when it's activated, all transport rides remain free too.

Hey, with the newest Version (1.1) I always get a red empty Box
With every load game, and every few seconds. (Every day the box)
Happen with newest Dev OpenRCT2 and older OpenRCT2 Versions
https://i.imgur.com/ijwgqFU.jpg

Thanks for this great plugin!

Problem
I saw that you haven't tested the plugin against multiplayer. I tried it today and can confirm that it still works if the person hosting the game has it installed. The prices are not synced to the other players, though.

Solution
I don't know if it's possible but at best the plugin could allow for syncing prices in multiplayer. Manual prices are already synced.

Alternatives
Alternatively, it could be possible to run the plugin on all clients. That's not possible at the moment.

Additional context
Tested with OpenRCT2 0.3.2 on Mac and Ubuntu.