The mgwdev-m365-helpers from mgwojciech

mgwdev-m365-helpers's People

Contributors

Stargazers

Watchers

mgwdev-m365-helpers's Issues

Readme details I noticed while having a first try

1️⃣ of all

Good job 💪 I only had a really quick overview on this with a simple spfx webpart but it seems to work pretty sweet 👍. You rock 🤩.

Potential 🪲s I found in readme

in the GraphODataPagedDataProvider example

let spfxGraphClient = this.context.aadHttpClientFactory.getClient('https://graph.microsoft.com');

let client = new BatchGraphClient(new SPFxGraphHttpClient(spfxGraphClient));
let pagedProvider = new GraphODataPagedDataProvider<any>(batchClient, "https://graph.microsoft.com/v1.0/users");
pagedProvider.pageSize = 10;

let users = await pagedProvider.getData();
let allUsers = pagedProvider.allItemsCount;
if(pagedProvider.isNextPageAvailable()){
    let nextPage = await pagedProvider.getNextPage();
}
if(pagedProvider.isPreviousPageAvailable()){
    let previousPage = await pagedProvider.getPreviousPage();
}

I think it should be let batchClient = new BatchGraphClient(new SPFxGraphHttpClient(spfxGraphClient)); right 🤔?

in the spfx example

let spfxGraphClient = this.context.aadHttpClientFactory.getClient('https://graph.microsoft.com');

let client = new BatchGraphClient(new SPFxGraphHttpClient(spfxGraphClient));

let [me, photo, presence] = await Promise.all([
    client.get("https://graph.microsoft.com/v1.0/me"),
    client.get("https://graph.microsoft.com/v1.0/me/presence"),
    client.get("https://graph.microsoft.com/v1.0/me/photo/$value")
])

If I am not mistaking the aadHttpClientFactory.getClient() returns a Promise<AadHttpClient> so I think we should await it like
let spfxGraphClient = await this.context.aadHttpClientFactory.getClient('https://graph.microsoft.com');

Recommend Projects