mholt / caddy-embed Goto Github PK

On my machine the build take about 9 hour and still running, so I terminate it. Do you know why this is happen?

I'm using Ubuntu 22.04.2 LTS, go version 1.20.6, xcaddy v0.3.4

Step to reproduce

1. Install xcaddy: sudo apt install xcaddy
2. Clone the repo: git clone https://github.com/mholt/caddy-embed.git && cd caddy-embed
3. Build Caddy with plugin: xcaddy build --with github.com/mholt/caddy-embed=.

I tried reinstall xcaddy with go install github.com/caddyserver/xcaddy/cmd/xcaddy@latest and the output still the same. Do you think is xcaddy bug?

Currently, this approach has some UX problems. It requires cloning this repo and copying the files to embed to inside of the repo. This is awkward for various reasons, such as fighting with git with the files directory, having to clone at all meaning you have some extra directory sitting around, having to copy your files yourself (i.e. needing to write a script/Makefile to automate it), needing to modify module.go if you want to rename the embed, etc.

My suggestion is that we could move this to the https://github.com/caddyserver/xcaddy project, where it would be a build flag, i.e. xcaddy build --embed <path>. Then xcaddy would create the module.go file itself into a temp dir, optionally change the //go:embed line to use a different base path (maybe with another flag like --embed-dir), copy the given path (files to embed) to inside of the temp dir, then invoke the build as normal.

I think this would be significantly better UX, because there would be no need for messing around with git, no copying files by hand, no need to write your own build script to make it work as a repeated command. It would just become an argument to the xcaddy build command they (probably) already use.