miahnelah / better-entity-link Goto Github PK

Foundry 11.307
Module 1.2.3.1

The following error is generated when clicking the Reset button in a Card Stack. I've also seen it generated from other interactions in the various Card Stacks dialog windows.

When I post a link in a chat message, it would be nice if the popup menu when right-clicking on the link would also include your updated list of options.

My specific use case is to drag a table from a compendium on which players only have limited ownership into the chat log so that players can roll on the table (despite them not seeing it in the compendium list). This is more convenient then forcing open a journal window on everybody's screens for them to right-click on the link to roll on the table.

Not sure if bug report or feature request. The title would solve this, but on further experimenting it may be a simpler fix.

Currently if you, for example, right click on a table that is the only text in its message, and its the bottom message in chat, the roll button gets cut off until you scroll down: https://gfycat.com/velvetyspecificacouchi

As you can see, once you've scrolled down once, it fixes itself for a while, but switching tabs away from/back to chat resets it to non-working. BEL is the only active module in that world.

The latest version is showing as unknown compatibility because you have "verfied" instead of "verified" in the compatibility field.

Very cool module. The only issue I'm running into is that the right-click context menu on entity links is available for all players, and players can activate any of the context menu options regardless of their permissions regarding that entity.

For example: I have a journal entry containing a link to a secret scene (Navigation disabled, GM only) and a link to a secret journal entry (None permissions). The player can bypass their lack of permissions by right-clicking the link and selecting View Scene and Show Players (Text)/Show Players (Image).

Add support for JournalEntryPage as well as JournalEntry.

Show image/text would definitely be appropriate, as would probably be configure ownership (although changing ownership on a page will have no effect if the containing JournalEntry doesn't have at least the same ownership).

Not sure if this is fixable on your end or has to be on theirs, but the (by default on) custom journal sheet entry PF2e uses breaks this mod's functionality. It's not a dealbreaker, but compatibility would be nice, if its easy to do?

https://gfycat.com/RedFatalJuliabutterfly

Foundry provides a "Jump to Pin" option in the Journal Sidebar.

It would be nice to have this available on links to journals.

Foundry's code for sidebar button is:

return options.concat([
      {
        name: "SIDEBAR.JumpPin",
        icon: '<i class="fas fa-crosshairs"></i>',
        condition: li => {
          const entry = game.journal.get(li.data("document-id"));
          return !!entry.sceneNote;
        },
        callback: li => {
          const entry = game.journal.get(li.data("document-id"));
          return entry.panToNote();
        }
      }
    ]);

Foundry shows this message "K is not defined" on install

Every time this module is updated, the user is prompted to change the location of the manifest. It would be far better if the "manifest" line in module.json referred to "latest/download" instead of an explicit version. (The "download" line should remain pointing to a specific version.

e.g., my PDF Pager module has the following lines in module.json:

    "url": "https://github.com/farling42/fvtt-pdf-pager",
    "manifest": "https://github.com/farling42/fvtt-pdf-pager/releases/latest/download/module.json",
    "download": "https://github.com/farling42/fvtt-pdf-pager/releases/download/0.48.2/module.zip",

I think this module is the right place to merge all these kind of features.
Can you merge the fetaure from the module Sound Link in this module ?

Hi!
I'm afraid the module stopped working in v11 for me, is there anything I can do to fix this? Or is this an update that needs to be fixed?

I love to use it, kudo's for making it :-)

Could we get an update that supports cards?

Pushing the module to foundry V9 would be great too.

Although the callback can be async, the condition is not async.

I know this will cause problems with trying to access contents of packs, but core Foundry expects the condition function to directly return a truthy rather than a Promise.

Jumping to a scene pin was recently added for Journal Entries. It would be nice to also work with pins to Journal Entry Pages.

Something similar to, but might want extra code to switch to the relevant scene (as done for the other JumpPin).

    BetterEntityLink.registerJournalEntryPageAction({
        name: "SIDEBAR.JumpPin",
        icon: "fa-crosshairs",
        condition: entity => !!entity.sceneNote,
        callback: async entity => canvas.notes.panToNote(entity.sceneNote)
    });