Giter VIP home page Giter VIP logo

Comments (3)

mxjeff avatar mxjeff commented on August 23, 2024

python-mpd was actually exposing multi-value tags as a list, which is fine I think.
I agree with you carnager, python-mpd2 should present them as a list as well.

But I'm not sure this is relevant to to merge duplicated tag values at the module level.
IMHO, the module should not try to infer what I'm expecting and modifies tags.

For instance here is how I handle it in my client:

class Track:
    """
    Track object.
    Instanciate with Player replies.
    """

    def __init__(self, **kwargs):
        self.title = self.artist = self.album = self.albumartist = ''
        self.__dict__.update(**kwargs)
        #  have tags been collapsed?
        self.collapsed_tags = list()
        # Needed for multiple tag values which returns a list instead of a string
        self.collapse_tags()

    def collapse_tags(self):
        """
        Necessary to deal with tags defined multiple times.
        These entries are set as lists instead of strings.
        """
        for tag, value in self.__dict__.items():
            if isinstance(value, list):
                self.collapsed_tags.append(tag)
                self.__dict__.update({tag: ', '.join(set(value))})

from python-mpd2.

Mic92 avatar Mic92 commented on August 23, 2024

I could not reproduce your bug. I have added a test here, where it returns a list. I have also tried:

echo "OK MPD 0.19.0\nTrack: file1\nTrack: file2\nOK\n" | nc -v -l localhost 6601
>>> import mpd
>>> c = mpd.MPDClient()
>>> c.connect("localhost", 6601)
>>> print(type(c.currentsong()['track']))
<class 'list'>

from python-mpd2.

carnager avatar carnager commented on August 23, 2024

I seriously don't know what i tested last night, but you are right... i guess mark this as invalid :P

from python-mpd2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.