Giter VIP home page Giter VIP logo

Comments (4)

stevelacey avatar stevelacey commented on July 30, 2024

+1 yes, this is annoying and seemingly unecessary

from reading-time.

stevelacey avatar stevelacey commented on July 30, 2024

@disklosr if you're simply looking for the on-page read time, you can actually write something pretty effective with just a few lines, I switched to this to avoid the problem:

var words = $('.post-body').text().trim().split(/\s+/g).length,
    wordsPerMinutes = 270;

$('.read-time').text(Math.ceil(words / wordsPerMinutes) + ' min')

I am still using this plugin, but only for the remote counting functionality.

from reading-time.

michael-lynch avatar michael-lynch commented on July 30, 2024

The reason why the target is assumed to be a child element of the selector is because there may be multiple articles on the same page, so there needs to be some kind of relationship between the selector and the target. I'm open to suggestions if you can think of a better way to maintain that relationship per article.

from reading-time.

stevelacey avatar stevelacey commented on July 30, 2024

I understand how that is useful functionality. Maybe if passed an object, the assumption should be that the user has taken care of it themselves.

I would expect the following scenarios to be supported:

If I wanted to do the contextualisation myself:

$('.post').each(function() {
  $(this).readTime({readingTimeTarget: $(this).find('.read-time')});
});

If I only have one post and don't care about contextualisation:

var $post = $('.post');

$post.readTime({readingTimeTarget: $post.siblings('.read-time')});

I get why yours works as it does, but I think it differs from the way other plugins implement similar functionality, which makes it a bit confusing.

from reading-time.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.