Comments (4)
+1 yes, this is annoying and seemingly unecessary
from reading-time.
@disklosr if you're simply looking for the on-page read time, you can actually write something pretty effective with just a few lines, I switched to this to avoid the problem:
var words = $('.post-body').text().trim().split(/\s+/g).length,
wordsPerMinutes = 270;
$('.read-time').text(Math.ceil(words / wordsPerMinutes) + ' min')
I am still using this plugin, but only for the remote counting functionality.
from reading-time.
The reason why the target is assumed to be a child element of the selector is because there may be multiple articles on the same page, so there needs to be some kind of relationship between the selector and the target. I'm open to suggestions if you can think of a better way to maintain that relationship per article.
from reading-time.
I understand how that is useful functionality. Maybe if passed an object, the assumption should be that the user has taken care of it themselves.
I would expect the following scenarios to be supported:
If I wanted to do the contextualisation myself:
$('.post').each(function() {
$(this).readTime({readingTimeTarget: $(this).find('.read-time')});
});
If I only have one post and don't care about contextualisation:
var $post = $('.post');
$post.readTime({readingTimeTarget: $post.siblings('.read-time')});
I get why yours works as it does, but I think it differs from the way other plugins implement similar functionality, which makes it a bit confusing.
from reading-time.
Related Issues (20)
- Problem if "wordCountTarget" is not in the selected tag. HOT 2
- Looping through multiple remote articles? HOT 3
- Bug: Target for remote files HOT 4
- Bower HOT 3
- IE8 Problem HOT 3
- Add new release to make changes available to bower users HOT 1
- readingTimeTarget anywhere HOT 1
- Publish as npm module HOT 2
- "each" method doesn't work with laravel foreach HOT 1
- HTML entities support in less than a minute string? HOT 1
- Languages like Chinese, Japanese, Vietnamese are not separated by blanks
- Not working on IE
- Support Chinese
- npm i whitfin/reading-time installs 1.0.0 instead of 2.0.0 HOT 1
- IE11 Problem HOT 1
- Only works with article
- Not displaying on certain pages
- Showing the number in different languages
- Reading time for chinese language alwas show "less than a minute"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reading-time.