michaelpapworth / jquery.navigate Goto Github PK

This is purely a QoL change.

The implementation of navigate on the time of this writing looks like so:

navigate: function (method) {
            var methods = {
                  // ...
            },

Hence every time we call navigate to generate urls:

$.navigate('url', ...)

The 'methods' object is generated again and again. This introduces an unnecessary overhead.

The solution: Refactor the implementation to move the 'methods' object outside of 'navigate()'.

Provide reasonable defaults for ESLint to streamline maintenance of the project.

Side-concerns:

In the same context we should provide reasonable VSCode settings in terms of

• The default document-formatter to employ for .js files.
• Making sure that said formatter is triggered automagically on each file-save.

We should use .attr() as a matter of best practice to play it safe against weird corner cases where the urls passed on to goTo() are malformed by stray single-quotes <<'>>.

With the new approach the resulting error should be way more clear.