Giter VIP home page Giter VIP logo

Comments (7)

lohedges avatar lohedges commented on July 22, 2024

Hi there.

Have you tried running this using the Exscientia fork? There have been a few one-way synchronisations (from us to them) recently, which have passed all of their internal checks, but there haven't been any synchronisations the other way. I've not written (or tested) any of this part of the codebase, so I'm not the best placed to answer.

However, the mdp files generated contained the line couple-moltype = , which should have been couple-moltype = LIG. mol._sire_object.name().value() was returning an empty string here.

This part of the code is identical in their fork, so presumably the same issue would occur. (Unless the name is being returning an empty string due to some Sire API changes?)

Tagging @xiki-tempula. Feel free to move this issue over to your fork if needed.

from biosimspace.

fjclark avatar fjclark commented on July 22, 2024

Thanks for the reply. I've just tried with the Exscientia fork and I still get the empty couple-moltype issue.

from biosimspace.

xiki-tempula avatar xiki-tempula commented on July 22, 2024

If you save the lig = BSS.Align.decouple(system[0]) into a gromacs topology, does it has a name?

from biosimspace.

fjclark avatar fjclark commented on July 22, 2024

Yes, its name is LIG, as with the input generated above. The end of the topology file shows

[ molecules ]
;molecule name    nr.
           LIG      1

Thanks.

from biosimspace.

xiki-tempula avatar xiki-tempula commented on July 22, 2024

@fjclark Can you load this topology file back in. Replacing the line system = BSS.IO.readMolecules(["input/SYSTEM.top", "input/SYSTEM.crd"])
and do everything again to see if it works?

from biosimspace.

fjclark avatar fjclark commented on July 22, 2024

@xiki-tempula that solves the issue. Now couple-moltype = LIG, and the gradients with respect to coul-lambdas and vdw-lambdas are non-zero. Thanks very much!

from biosimspace.

lohedges avatar lohedges commented on July 22, 2024

Thanks for solving. I'd suggest adding some fallback in case the input was generated via another means, since not all of the parsers apply a molecule name in this way, e.g. I'm not sure if it would always be persistent on save/load depending on the format.

from biosimspace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.