michielbouw / react-typescript-yarn-lerna-monorepo-eslint-prettier-boilerplate Goto Github PK

Just a quick question. I noticed in your monorepo .eslintrc file

"extends": [
    "react-app"
  ],

but I don't see eslint-config-react-app in your monorepo package.json file. Monorepo .eslintrc file is not CRA project so I think you need this dependency there?

When running Yarn install error message
"Workspaces can only be enabled in private projects"

Resolved via setting private to true in main package.json

@michielbouw - thanks for all your work on this - exactly what I was looking for - I will be running through it over the next few days so if I get any other issues will let you know.

I find you just do the build task,
but how to deploy the project?
for example: deploying a node server

Right now unless you use the fix mentioned here: facebook/create-react-app#8685 (comment) you are unable to use lerna with this project if you update to react-script version 3.4.1 or later.

To solve it for --parallel --stream start commands use CI=true env. variable. This is not good for the UI of the output, but it will still work.

Let's hope they will update this later on.

The following scripts can be simplified from

"start:www": "lerna run start --scope=\"@web/shared\" --scope=\"@web/utils\" --scope=\"@web/www\" --parallel"

to

"start:www": "lerna run start --scope=@web/{shared,utils,www} --parallel"

One question in relation to this as they run all packages in scope are they required?